Tweak Symbol and InternedString
#60659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors try |
bors
added a commit
that referenced
this pull request
May 9, 2019
…=<try> Tweak `Symbol` and `InternedString` Some minor improvements to speed and code cleanliness. r? @Zoxc
|
☀️ Try build successful - checks-travis |
|
@rust-timer build 9a6dab6 |
|
Success: Queued 9a6dab6 with parent 9f83961, comparison URL. |
|
I got miniscule improvements locally, but I think it's worthwhile from the clean-up angle. |
petrochenkov
reviewed
May 9, 2019
petrochenkov
reviewed
May 9, 2019
petrochenkov
reviewed
May 9, 2019
| // | ||
| // FIXME: ensure that the interner outlives any thread which uses | ||
| // `LocalInternedString`, by creating a new thread right after constructing the | ||
| // interner. |
There was a problem hiding this comment.
@Zoxc , I don't think this FIXME is necessary?
There was a problem hiding this comment.
I assumed this is already true due to how GLOBALS and threads are created.
There was a problem hiding this comment.
I think it happens do be done that way now, but it's not enforced or documented as required by symbol.rs.
petrochenkov
reviewed
May 9, 2019
petrochenkov
reviewed
May 9, 2019
|
Could you revert the |
petrochenkov
added
S-waiting-on-author
|
Finished benchmarking try commit 9a6dab6 |
This lets comparisons occur with a single access to the interner, instead of two.
Lots of details I wish I'd known when I first looked at this code.
It's not used.
nnethercote
force-pushed
the
tweak-Symbol-and-InternedString
branch
from
3e5e8d3 to
e53bb1a
Compare
|
@petrochenkov: New code is up. |
Zoxc
reviewed
May 10, 2019
| @@ -367,10 +380,6 @@ impl Symbol { | |||
| with_interner(|interner| interner.intern(string)) | |||
| } | |||
|
|
|||
| pub fn interned(self) -> Self { | |||
petrochenkov
removed
the
S-waiting-on-author
petrochenkov
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit e53bb1a has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
May 10, 2019
…edString, r=Zoxc Tweak `Symbol` and `InternedString` Some minor improvements to speed and code cleanliness. r? @Zoxc
bors
added a commit
that referenced
this pull request
May 10, 2019
Rollup of 6 pull requests Successful merges: - #60529 (RFC 2008: Uninhabitedness fixes for enum variants and tests) - #60620 (Fix a couple of FIXMEs in ext::tt::transcribe) - #60659 (Tweak `Symbol` and `InternedString`) - #60692 (Extend #60676 test for nested mut patterns.) - #60697 (add regression test for #60629) - #60701 (Update mailmap for mati865) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor improvements to speed and code cleanliness.
r? @Zoxc