Fix #45268 by saving all NodeId's for resolved traits. #60415

jespersm · 2019-04-30T14:05:03Z

This fixes #45268 by saving all NodeId's for resolved traits.

I've verifies this against master (but only on MacOS). However, with some recent changes in master, it appears that there are some failures on my machine. They are unrelated to my changes, anyway.

rust-highfive · 2019-04-30T14:05:15Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

oli-obk · 2019-04-30T14:07:07Z

r? @petrochenkov

src/librustc/ich/impls_hir.rs

src/librustc_resolve/lib.rs

rust-highfive · 2019-04-30T15:21:49Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:1a26b0c4:start=1556633167249527871,finish=1556633168209992226,duration=960464355
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_ui
Check compiletest suite=ui mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:11:57] 
[01:11:57] running 5472 tests
[01:12:00] ........................................................................................F........... 100/5472
[01:12:06] .................................................................................................... 300/5472
[01:12:09] .................................................................................................... 400/5472
[01:12:13] ...........................................................................................i........ 500/5472
[01:12:17] .................................................................................................... 600/5472
---
[01:14:56] .................................................................................................... 4700/5472
[01:15:01] .................................................................................................... 4800/5472
[01:15:04] .................................................................................................... 4900/5472
[01:15:09] .................................................................................................... 5000/5472
[01:15:12] .................................F..F............................................................... 5100/5472
[01:15:19] .................................................................................................... 5300/5472
[01:15:22] .................................................................................................... 5400/5472
[01:15:25] ..........i.............................................................
[01:15:25] failures:
[01:15:25] failures:
[01:15:25] 
[01:15:25] ---- [ui] ui/associated-types/associated-types-overridden-binding-2.rs stdout ----
[01:15:25] 
[01:15:25] error: Error: expected failure status (Some(1)) but received status Some(101).
[01:15:25] status: exit code: 101
[01:15:25] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/associated-types/associated-types-overridden-binding-2.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-types/associated-types-overridden-binding-2/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-types/associated-types-overridden-binding-2/auxiliary" "-A" "unused"
[01:15:25] ------------------------------------------
[01:15:25] 
[01:15:25] ------------------------------------------
[01:15:25] stderr:
[01:15:25] stderr:
[01:15:25] ------------------------------------------
[01:15:25] error: internal compiler error: src/librustc/hir/map/mod.rs:632: couldn't find hir id HirId { owner: DefIndex(0:0), local_id: 0 } in the HIR map
[01:15:25] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:643:9
[01:15:25] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:15:25] error: aborting due to previous error
[01:15:25] 
[01:15:25] 
[01:15:25] 
[01:15:25] note: the compiler unexpectedly panicked. this is a bug.
[01:15:25] 
[01:15:25] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:15:25] 
[01:15:25] note: rustc 1.36.0-dev running on x86_64-unknown-linux-gnu
[01:15:25] 
[01:15:25] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -C prefer-dynamic -C rpath
[01:15:25] 
[01:15:25] ------------------------------------------
[01:15:25] 
[01:15:25] 
[01:15:25] 
[01:15:25] ---- [ui] ui/traits/trait-alias-ambiguous.rs stdout ----
[01:15:25] 
[01:15:25] error: Error: expected failure status (Some(1)) but received status Some(101).
[01:15:25] status: exit code: 101
[01:15:25] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/traits/trait-alias-ambiguous.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/trait-alias-ambiguous/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/trait-alias-ambiguous/auxiliary" "-A" "unused"
[01:15:25] ------------------------------------------
[01:15:25] 
[01:15:25] ------------------------------------------
[01:15:25] stderr:
[01:15:25] stderr:
[01:15:25] ------------------------------------------
[01:15:25] error: internal compiler error: src/librustc/hir/map/mod.rs:632: couldn't find hir id HirId { owner: DefIndex(0:0), local_id: 0 } in the HIR map
[01:15:25] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:643:9
[01:15:25] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:15:25] error: aborting due to previous error
[01:15:25] 
[01:15:25] 
[01:15:25] 
[01:15:25] note: the compiler unexpectedly panicked. this is a bug.
[01:15:25] 
[01:15:25] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:15:25] 
[01:15:25] note: rustc 1.36.0-dev running on x86_64-unknown-linux-gnu
[01:15:25] 
[01:15:25] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -C prefer-dynamic -C rpath
[01:15:25] 
[01:15:25] ------------------------------------------
[01:15:25] 
[01:15:25] 
[01:15:25] 
[01:15:25] ---- [ui] ui/traits/trait-alias-object.rs stdout ---et _: &dyn IteratorAlias = &vec![123].into_iter(); //~ ERROR must be specified
[01:15:25]    |             ^^^^^^^^^^^^^^^^^ associated type `Item` must be specified
[01:15:25] 
[01:15:25] error: internal compiler error: src/librustc/hir/map/mod.rs:632: couldn't find hir id HirId { owner: DefIndex(0:0), local_id: 0 } in the HIR map
[01:15:25] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:643:9
[01:15:25] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:15:25] error: aborting due to 3 previous errors
[01:15:25] 
---
[01:15:25] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:15:25] 
[01:15:25] note: rustc 1.36.0-dev running on x86_64-unknown-linux-gnu
[01:15:25] 
[01:15:25] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -C prefer-dynamic -C rpath
[01:15:25] 
[01:15:25] ------------------------------------------
[01:15:25] 
[01:15:25] 
---
[01:15:25]     [ui] ui/traits/trait-alias-object.rs
[01:15:25] 
[01:15:25] test result: FAILED. 5448 passed; 3 failed; 21 ignored; 0 measured; 0 filtered out
[01:15:25] 
[01:15:25] thread 'main' pted unsuccessfully in 0:04:28
[01:15:25] Makefile:48: recipe for target 'check' failed
[01:15:25] make: *** [check] Error 1

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/test/ui/lint/unused_import_warning_issue_45268.rs

src/librustc_typeck/check/method/probe.rs

src/librustc_typeck/check/method/mod.rs

src/librustc/hir/mod.rs

src/librustc/ich/impls_hir.rs

src/librustc_resolve/lib.rs

petrochenkov · 2019-05-01T13:19:43Z

From ICEs found by CI it looks like DUMMY_NODE_ID somehow gets into import_ids list in resolve?
You'll have to find out what import it comes from and exclude it.

rust-highfive · 2019-05-01T14:29:15Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:19a1df78:start=1556716746247055212,finish=1556716831470755227,duration=85223700015
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_ui
Check compiletest suite=ui mode=ui (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:05:14] 
[01:05:14] running 5476 tests
[01:05:17] ........................................................................................F........... 100/5476
[01:05:23] .................................................................................................... 300/5476
[01:05:26] .................................................................................................... 400/5476
[01:05:29] ...........................................................................................i........ 500/5476
[01:05:33] .................................................................................................... 600/5476
---
[01:08:00] .................................................................................................... 4700/5476
[01:08:05] .................................................................................................... 4800/5476
[01:08:08] .................................................................................................... 4900/5476
[01:08:12] .................................................................................................... 5000/5476
[01:08:16] .....................................F..F........................................................... 5100/5476
[01:08:22] .................................................................................................... 5300/5476
[01:08:25] .................................................................................................... 5400/5476
[01:08:27] ..............i.............................................................
[01:08:27] failures:
[01:08:27] failures:
[01:08:27] 
[01:08:27] ---- [ui] ui/associated-types/associated-types-overridden-binding-2.rs stdout ----
[01:08:27] 
[01:08:27] error: Error: expected failure status (Some(1)) but received status Some(101).
[01:08:27] status: exit code: 101
[01:08:27] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/associated-types/associated-types-overridden-binding-2.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-types/associated-types-overridden-binding-2/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-types/associated-types-overridden-binding-2/auxiliary" "-A" "unused"
[01:08:27] ------------------------------------------
[01:08:27] 
[01:08:27] ------------------------------------------
[01:08:27] stderr:
[01:08:27] stderr:
[01:08:27] ------------------------------------------
[01:08:27] error: internal compiler error: src/librustc/hir/map/mod.rs:632: couldn't find hir id HirId { owner: DefIndex(0:0), local_id: 0 } in the HIR map
[01:08:27] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:643:9
[01:08:27] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:08:27] error: aborting due to previous error
[01:08:27] 
[01:08:27] 
[01:08:27] 
[01:08:27] note: the compiler unexpectedly panicked. this is a bug.
[01:08:27] 
[01:08:27] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:08:27] 
[01:08:27] note: rustc 1.36.0-dev running on x86_64-unknown-linux-gnu
[01:08:27] 
[01:08:27] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -C prefer-dynamic -C rpath
[01:08:27] 
[01:08:27] ------------------------------------------
[01:08:27] 
[01:08:27] 
[01:08:27] 
[01:08:27] ---- [ui] ui/traits/trait-alias-ambiguous.rs stdout ----
[01:08:27] 
[01:08:27] error: Error: expected failure status (Some(1)) but received status Some(101).
[01:08:27] status: exit code: 101
[01:08:27] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/traits/trait-alias-ambiguous.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/trait-alias-ambiguous/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/trait-alias-ambiguous/auxiliary" "-A" "unused"
[01:08:27] ------------------------------------------
[01:08:27] 
[01:08:27] ------------------------------------------
[01:08:27] stderr:
[01:08:27] stderr:
[01:08:27] ------------------------------------------
[01:08:27] error: internal compiler error: src/librustc/hir/map/mod.rs:632: couldn't find hir id HirId { owner: DefIndex(0:0), local_id: 0 } in the HIR map
[01:08:27] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:643:9
[01:08:27] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:08:27] error: aborting due to previous error
[01:08:27] 
[01:08:27] 
[01:08:27] 
[01:08:27] note: the compiler unexpectedly panicked. this is a bug.
[01:08:27] 
[01:08:27] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:08:27] 
[01:08:27] note: rustc 1.36.0-dev running on x86_64-unknown-linux-gnu
[01:08:27] 
[01:08:27] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -C prefer-dynamic -C rpath
[01:08:27] 
[01:08:27] ------------------------------------------
[01:08:27] 
[01:08:27] 
[01:08:27] 
[01:08:27] ---- [ui] ui/traits/trait-alias-object.rs stdout ----
[01:08:27] 
[01:08:27] error: Error: expected failure status (Some(1)) but received status Some(101).
[01:08:27] status: exit code: 101
[01:08:27] command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/traits/trait-alias-object.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/trait-alias-object/a" "-Crpath" "-O" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/traits/trait-alias-object/auxiliary" "-A" "unused"
[01:08:27] ------------------------------------------
[01:08:27] 
[01:08:27] ------------------------------------------
[01:08:27] stderr:
[01:08:27] stderr:
[01:08:27] ------------------------------------------
[01:08:27] error[E0038]: the trait `EqAlias` cannot be made into an object
[01:08:27]    |
[01:08:27]    |
[01:08:27] LL |     let _: &dyn EqAlias = &123; //~ ERROR `EqAlias` cannot be made into an object
[01:08:27]    |             ^^^^^^^^^^^ the trait `EqAlias` cannot be made into an object
[01:08:27]    = note: the trait cannot use `Self` as a type parameter in the supertraits or where-clauses
[01:08:27] 
[01:08:27] 
[01:08:27] error[E0191]: the value of the associated type `Item` (from the trait `std::iter::Iterator`) must be specified
[01:08:27]    |
[01:08:27]    |
[01:08:27] LL |     let _: &dyn IteratorAlias = &vec![123].into_iter(); //~ ERROR must be specified
[01:08:27]    |             ^^^^^^^^^^^^^^^^^ associated type `Item` must be specified
[01:08:27] 
[01:08:27] error: internal compiler error: src/librustc/hir/map/mod.rs:632: couldn't find hir id HirId { owner: DefIndex(0:0), local_id: 0 } in the HIR map
[01:08:27] thread 'rustc' panicked at 'Box<Any>', src/librustc_errors/lib.rs:643:9
[01:08:27] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:08:27] error: aborting due to 3 previous errors
[01:08:27] 
---
[01:08:27] note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports
[01:08:27] 
[01:08:27] note: rustc 1.36.0-dev running on x86_64-unknown-linux-gnu
[01:08:27] 
[01:08:27] note: compiler flags: -Z threads=1 -Z ui-testing -Z unstable-options -C prefer-dynamic -C rpath
[01:08:27] 
[01:08:27] ------------------------------------------
[01:08:27] 
[01:08:27] 
---
[01:08:27] thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:519:22
[01:08:27] note: Run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
[01:08:27] 
[01:08:27] 
[01:08:27] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
[01:08:27] 
[01:08:27] 
[01:08:27] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:08:27] Build completed unsuccessfully in 0:04:10
[01:08:27] Build completed unsuccessfully in 0:04:10
[01:08:27] make: *** [check] Error 1
[01:08:27] Makefile:48: recipe for target 'check' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:098bea48
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Wed May  1 14:29:07 UTC 2019
---
travis_time:end:0214b825:start=1556720949058923444,finish=1556720949065924552,duration=7001108
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:11d18fa8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2e268658
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

jespersm · 2019-05-01T18:16:09Z

I think I found the source of the ICE, so I hope to be able to push a fix in a little while.

src/librustc/ich/impls_hir.rs

src/librustc_typeck/check/method/probe.rs

jespersm · 2019-05-02T14:44:49Z

I'm done here -- any remaining review comments exceed my Rust skills...

r? petrochenkov

src/librustc_data_structures/stable_hasher.rs

petrochenkov · 2019-05-02T16:17:48Z

One last fix and it's ready to go.

jespersm · 2019-05-02T19:54:12Z

One last fix and it's ready to go.

Done (Travis is chewing on it now)

petrochenkov · 2019-05-04T09:14:08Z

@jespersm
This needs a rebase now.

jespersm · 2019-05-04T15:52:08Z

Whoops, forgot fetch before rebase. Fixing the DefKind refactoring now.

rust-highfive · 2019-05-04T16:13:30Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0a613518:start=1556986240170629819,finish=1556986242456221808,duration=2285591989
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
####################################################                      72.5%
######################################################################## 100.0%
[00:02:03] extracting /checkout/obj/build/cache/2019-04-11/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:02:04]     Updating crates.io index
[00:02:21] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:21] Build completed unsuccessfully in 0:00:36
[00:02:21] Makefile:69: recipe for target 'prepare' failed
[00:02:21] make: *** [prepare] Error 1
[00:02:22] Command failed. Attempt 2/5:
[00:02:22] Command failed. Attempt 2/5:
[00:02:22] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:22] Build completed unsuccessfully in 0:00:00
[00:02:22] Makefile:69: recipe for target 'prepare' failed
[00:02:22] make: *** [prepare] Error 1
[00:02:24] Command failed. Attempt 3/5:
[00:02:24] Command failed. Attempt 3/5:
[00:02:25] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:25] Build completed unsuccessfully in 0:00:00
[00:02:25] make: *** [prepare] Error 1
[00:02:25] Makefile:69: recipe for target 'prepare' failed
[00:02:28] Command failed. Attempt 4/5:
[00:02:28] Command failed. Attempt 4/5:
[00:02:28] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:28] Build completed unsuccessfully in 0:00:00
[00:02:28] make: *** [prepare] Error 1
[00:02:28] Makefile:69: recipe for target 'prepare' failed
[00:02:32] Command failed. Attempt 5/5:
[00:02:32] Command failed. Attempt 5/5:
[00:02:33] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:33] Build completed unsuccessfully in 0:00:00
[00:02:33] Makefile:69: recipe for target 'prepare' failed
[00:02:33] make: *** [prepare] Error 1
[00:02:33] The command has failed after 5 attempts.
---
travis_time:end:006abe86:start=1556986406905518760,finish=1556986406911947458,duration=6428698
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0f87584a
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:086ff790
travis_time:start:086ff790
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:132887d9
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-05-04T19:17:18Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:0bc7439e:start=1556997288580458852,finish=1556997290710627084,duration=2130168232
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
#########################                                                 35.3%
######################################################################## 100.0%
[00:01:34] extracting /checkout/obj/build/cache/2019-04-11/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:34]     Updating crates.io index
[00:01:50] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:01:50] Build completed unsuccessfully in 0:00:38
[00:01:50] Makefile:69: recipe for target 'prepare' failed
[00:01:50] make: *** [prepare] Error 1
[00:01:51] Command failed. Attempt 2/5:
[00:01:51] Command failed. Attempt 2/5:
[00:01:52] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:01:52] Build completed unsuccessfully in 0:00:00
[00:01:52] make: *** [prepare] Error 1
[00:01:52] Makefile:69: recipe for target 'prepare' failed
[00:01:54] Command failed. Attempt 3/5:
[00:01:54] Command failed. Attempt 3/5:
[00:01:54] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:01:54] Build completed unsuccessfully in 0:00:00
[00:01:54] make: *** [prepare] Error 1
[00:01:54] Makefile:69: recipe for target 'prepare' failed
[00:01:57] Command failed. Attempt 4/5:
[00:01:57] Command failed. Attempt 4/5:
[00:01:58] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:01:58] Build completed unsuccessfully in 0:00:00
[00:01:58] Makefile:69: recipe for target 'prepare' failed
[00:01:58] make: *** [prepare] Error 1
[00:02:02] Command failed. Attempt 5/5:
[00:02:02] Command failed. Attempt 5/5:
[00:02:02] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:02] Build completed unsuccessfully in 0:00:00
[00:02:02] Makefile:69: recipe for target 'prepare' failed
[00:02:02] make: *** [prepare] Error 1
[00:02:02] The command has failed after 5 attempts.
---
travis_time:end:03a46d18:start=1556997426076778663,finish=1556997426081957990,duration=5179327
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0cc1e63a
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1a038bce
travis_time:start:1a038bce
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:2437d7d6
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

jespersm · 2019-05-04T19:21:24Z

@petrochenkov : I can't make this work, help needed.

After the rebase, Travis won't build, but the build works fine here without any version changes on Cargo.lock
I can't run the same commands as Travis does.

petrochenkov · 2019-05-04T21:06:13Z

Weird. Let me look.

petrochenkov · 2019-05-04T21:29:47Z

So, what happened is that the first commit (5deec30) got an unexpected addition to Cargo.lock during rebase.
The fix was to run the build after rebase, cargo would automatically fixup Cargo.lock in that case.
(I've pushed the commit with the fixup.)

@bors r+

bors · 2019-05-04T21:29:48Z

📌 Commit f5b5ca8 has been approved by petrochenkov

bors · 2019-05-04T21:50:19Z

⌛ Testing commit f5b5ca8 with merge 747dd57...

Fix #45268 by saving all NodeId's for resolved traits. This fixes #45268 by saving all NodeId's for resolved traits. I've verifies this against master (but only on MacOS). However, with some recent changes in master, it appears that there are some failures on my machine. They are unrelated to my changes, anyway.

bors · 2019-05-05T00:40:27Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: petrochenkov
Pushing 747dd57 to master...

rust-highfive assigned oli-obk Apr 30, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 30, 2019

rust-highfive assigned petrochenkov and unassigned oli-obk Apr 30, 2019

jespersm commented Apr 30, 2019

View reviewed changes

src/librustc/ich/impls_hir.rs Outdated Show resolved Hide resolved

jespersm commented Apr 30, 2019

View reviewed changes

src/librustc_resolve/lib.rs Outdated Show resolved Hide resolved