-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo FromIterator
short-circuiting
#59362
Merged
bors
merged 4 commits into
rust-lang:master
from
pnkfelix:demo-from-iterator-short-circuiting
Mar 26, 2019
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
48af718
Expand `impl FromIterator for Option` doc to include example of early…
pnkfelix d5a61c0
Expand `impl FromIterator for Result` doc to include examples of `Err…
pnkfelix 6315221
Update src/libcore/option.rs
killercup 0e83e96
add missing braces
pnkfelix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as a question from a relative newbie: What is this
3_u16
syntax? I have seen the3u16
syntax but never with the underscore. Is there a difference between this syntax?I would suggest that using
3u16
or evenlet items: Vec<u16>= vec![3, 2, 1, 10];
to make it more clear for people that are not too experienced with Rust. But that is just my humble opinion!EDIT: Nice examples by the way! I never knew it worked this way :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
_
here is merely an effect of separators in numeric literals, e.g.3_000_000_u32
or3_000____u32
. The underscores are for readability and have no effect otherwise.3u16
and3_u16
are thus equivalent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright! Thanks for sharing! :)