Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement check_attribute to forbid #[allow_internal_unsafe] #57467

Merged
merged 10 commits into from
Jan 15, 2019
Merged

Implement check_attribute to forbid #[allow_internal_unsafe] #57467

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6a90f14
Add check_attribute
JohnTitor Jan 9, 2019
3cf3ed7
Separate the description on different lines
JohnTitor Jan 9, 2019
ea5197c
Add PartialEq
JohnTitor Jan 14, 2019
f18ae26
Run lint for unsafe on the ast
JohnTitor Jan 14, 2019
60a68be
Make UnsafeCode EarlyLintPass
JohnTitor Jan 14, 2019
efd111e
Add test
JohnTitor Jan 14, 2019
a7623e7
Add error check
JohnTitor Jan 14, 2019
d04f756
Restore error message
JohnTitor Jan 15, 2019
b39e9e2
Change from _ to None
JohnTitor Jan 15, 2019
bd1551e
Fix tests
JohnTitor Jan 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/librustc_lint/builtin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,12 @@ impl UnsafeCode {
}

impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UnsafeCode {
fn check_attribute(&mut self, cx: &LateContext, attr: &ast::Attribute) {
if attr.check_name("allow_internal_unsafe") {
self.report_unsafe(cx, attr.span, "`allow_internal_unsafe` allows defining macros using unsafe without triggering the `unsafe_code` lint at their call site");
JohnTitor marked this conversation as resolved.
Show resolved Hide resolved
}
}

fn check_expr(&mut self, cx: &LateContext, e: &hir::Expr) {
if let hir::ExprKind::Block(ref blk, _) = e.node {
// Don't warn about generated blocks, that'll just pollute the output.
Expand Down