Forward rust version number to tools #56134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Clippy uses it to identify the correct documentation to point to
oli-obk
force-pushed
the
clippy_documentation
branch
from
1bc1058 to
33efce1
Compare
oli-obk
added
the
beta-nominated
|
Beta nominating to get rustup clippy to point to docs that actually correspond to the lints in the code |
|
@bors r+ p=1 |
|
📌 Commit 33efce1 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Nov 21, 2018
Forward rust version number to tools Clippy uses it to identify the correct documentation to point to cc @Manishearth @nrc sibling PR in clippy: rust-lang/rust-clippy#3442
|
@oli-obk does clippy itself need a backport to take advantage of this? Or do we just need to backport this patch |
|
Clippy needs a backport, too. the sibling PR in the op must also be added |
|
Sure thing, although should clippy have been included in this PR? |
|
☀️ Test successful - status-appveyor, status-travis |
oli-obk
added
the
T-dev-tools
alexcrichton
added
beta-accepted
bors
added a commit
that referenced
this pull request
Nov 23, 2018
[beta] Rollup backports * #56163: [master] Backport 1.30.1 release notes * #56147: resolve: Fix some asserts in import validation * #56118: Update books for Rust 2018 * #56117: resolve: Make "empty import canaries" invisible from other crates * #56065: Replace the ICEing on const fn loops with an error * #56143: Issue 56128 segment id ice nightly * #56134: Fix clippy documentation links (first in #56156) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clippy uses it to identify the correct documentation to point to
cc @Manishearth @nrc
sibling PR in clippy: rust-lang/rust-clippy#3442