Fix validation false positive #55474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
oli-obk
added
the
beta-nominated
RalfJung
reviewed
Oct 29, 2018
|
@bors r+ |
|
📌 Commit 3e9d7e8 has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Oct 30, 2018
…Jung Fix validation false positive Fixes rust-lang#55454 r? @RalfJung
bors
added a commit
that referenced
this pull request
Oct 30, 2018
Rollup of 12 pull requests Successful merges: - #54885 (Don't lint 'unused_parens` on `if (break _) { .. }`) - #55205 (Improve a few cases of collecting to an FxHash(Map/Set)) - #55450 (msp430: remove the whole Atomic* API) - #55459 (Add UI test for #49296) - #55472 (Use opt.take() instead of mem::replace(opt, None)) - #55473 (Take advantage of impl Iterator in (transitive/elaborate)_bounds) - #55474 (Fix validation false positive) - #55476 (Change a flat_map with 0/1-element vecs to a filter_map) - #55487 (Adjust Ids of path segments in visibility modifiers) - #55493 (Doc fixes) - #55494 (borrowck=migrate must look at parents of closures) - #55496 (Update clippy) Failed merges: r? @ghost
Mark-Simulacrum
added
the
beta-accepted
|
Can you provide a PR with this patch applied to the beta branch? This doesn't cherry-pick cleanly, and I'm not familiar enough with this part of the codebase to fix the conflicts myself. |
pietroalbini
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Nov 1, 2018
[beta] Fix wrong validation clasisfication of `Option<&T>::Some` values r? @pietroalbini original PR: #55474
jethrogb
pushed a commit
to jethrogb/rust
that referenced
this pull request
Nov 21, 2018
This includes rust-lang#55474 which is needed to build rust-lang#56066
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55454
r? @RalfJung