-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
submodules: update clippy from 9d337313 to 5afdf8b7 #55084
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: ```` fix for rustc master mem_forget: fix syntax error in code sample explicit_counter_loop fix rust-lang#3308 false positive new_ret_no_self test remove tool lints cfg flag Added new_ret_no_self exception to clippy to pass dogfood tests Removed new_ret_no_self tests from method.rs new_ret_no_self correctly lint impl return Removed unused variables new_ret_no_self fix false positive for impl trait return with associated type self new_ret_no_self corrected panic and added test stderr new_ret_no_self added positive test cases Fix some more `stutter` warnings unused unit lint Install Windows SDK 10.0 on travis cmp_owned refactor cmp_owned correct error message if rhs is deref Add a comment reminding to update README if the default changes Specify which categories are enabled by default Only run markdown linter on linux Move Travis Windows build to allowed failures Add Travis windows build Fix `doc_markdown` lints Fix `stutter` lints Fix `similar_names` warnings cmp_owned current suggestion for multiple deref cmp_owned add test for multiple dereference Corrected single-character string constant used as pattern found in dogfood test Fixes 3289, cmp_owned wording and false positive ````
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 15, 2018
r? @oli-obk |
@bors r+ |
📌 Commit 5086280 has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 15, 2018
bors
added a commit
that referenced
this pull request
Oct 15, 2018
submodules: update clippy from 9d33731 to 5afdf8b Should fix toolstate. Changes: ```` fix for rustc master mem_forget: fix syntax error in code sample explicit_counter_loop fix #3308 false positive new_ret_no_self test remove tool lints cfg flag Added new_ret_no_self exception to clippy to pass dogfood tests Removed new_ret_no_self tests from method.rs new_ret_no_self correctly lint impl return Removed unused variables new_ret_no_self fix false positive for impl trait return with associated type self new_ret_no_self corrected panic and added test stderr new_ret_no_self added positive test cases Fix some more `stutter` warnings unused unit lint Install Windows SDK 10.0 on travis cmp_owned refactor cmp_owned correct error message if rhs is deref Add a comment reminding to update README if the default changes Specify which categories are enabled by default Only run markdown linter on linux Move Travis Windows build to allowed failures Add Travis windows build Fix `doc_markdown` lints Fix `stutter` lints Fix `similar_names` warnings cmp_owned current suggestion for multiple deref cmp_owned add test for multiple dereference Corrected single-character string constant used as pattern found in dogfood test Fixes 3289, cmp_owned wording and false positive ````
☀️ Test successful - status-appveyor, status-travis |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Oct 15, 2018
Tested on commit rust-lang/rust@2a5de33. Direct link to PR: <rust-lang/rust#55084> 🎉 clippy-driver on windows: build-fail → test-pass. 🎉 clippy-driver on linux: build-fail → test-pass. 🎉 rls on windows: build-fail → test-pass. 🎉 rls on linux: build-fail → test-pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix toolstate.
Changes: