Add mutex to linenoise calls in std::rl #5312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we make this not one huge lock? Huge locks worry me. We should probably have real globals first. |
|
Hmm, I agree that there is a better way to handle this stuff, and that maybe it does just have to wait for the globals api. Thanks. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 2, 2020
…ation, r=flip1995 Document that wildcard_imports doesn't warn about `use ...::prelude::*;` changelog: Improve [`wildcard_imports`] documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4758
Is it sufficient to reuse the preexisting lock function? Currently all globals must pass through a single mutex anyway. That does make this an anti-climactic fix.