pretty print BTreeSet #53112
Merged
pretty print BTreeSet #53112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Do we have any sort of tests for this code? cc @michaelwoerister @tromey |
|
Also .. I'm probably not the best reviewer here ... one of you two care to pick this up? |
|
I found I should write test here. https://github.com/rust-lang/rust/blob/4ecf12bf0eb8386626ccdb5f721a7183ccc4eba6/src/test/debuginfo/pretty-std.rs |
|
@nikomatsakis, I'll take it.
@fukatani, yes, that would be great. I don't know why this test is ignored at the moment. |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@michaelwoerister Could you review this PR? |
|
Thanks a lot, @fukatani! Looks great. I'm wondering though if Also, to make things more consistent with the other collection printers, could you make it |
|
Current PR behavior is the same as #include <set>
int main() {
std::set<int> map;
map.insert(5);
map.insert(6);
return 0;
}I agree that it's a bit redundant. |
|
So far we have not made any effort to match C++'s pretty printers. I'd rather have the Rust pretty printers be consistent among each other. |
|
FWIW the libstdc++ |
|
@michaelwoerister |
|
📌 Commit 6e562d2 has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Aug 14, 2018
…ichaelwoerister
pretty print BTreeSet
I want pretty printing for BTreeSet.
```rust
use std::collections::*;
fn main() {
let mut s = BTreeSet::new();
s.insert(5);
s.insert(3);
s.insert(7);
s.remove(&3);
println!("{:?}", s);
}
```
```
(gdb) b 9
(gdb) p s
$1 = BTreeSet<i32> with 2 elements = {[0] = 5, [1] = 7}
```
This is analogy of pretty printing for C++ std::set.
bors
added a commit
that referenced
this pull request
Aug 14, 2018
Rollup of 11 pull requests Successful merges: - #53112 (pretty print BTreeSet) - #53208 (Don't panic on std::env::vars() when env is null.) - #53226 (driver: set the syntax edition in phase 1) - #53229 (Make sure rlimit is only ever increased) - #53233 (targets: aarch64: Add bare-metal aarch64 target) - #53239 (rustc_codegen_llvm: Restore the closure env alloca hack for LLVM 5.) - #53246 (A few cleanups) - #53257 (Idiomatic improvements to IP method) - #53274 (Remove statics field from CodegenCx) - #53290 (Make LLVM emit assembly comments with -Z asm-comments) - #53317 (Mark prior failure to avoid ICE)
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Aug 17, 2018
…ichaelwoerister Pretty print btreemap for GDB Merge rust-lang#53112 first, please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want pretty printing for BTreeSet.
This is analogy of pretty printing for C++ std::set.