-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated RELEASES.md for 1.27.0 #51261
Conversation
RELEASES.md
Outdated
now stable.][48851] e.g. | ||
`fn foo<#[lifetime_attr] 'a, #[type_attr] T: 'a>() {}` | ||
- [The `#[must_use]` attribute can now also be used on functions as well as | ||
types.][48925] Which provides a lint that by default warns users when the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Which/it
RELEASES.md
Outdated
- [`HashMap::remove_entry`] | ||
- [`Take::set_limit`] | ||
- [`fs::read`] | ||
- [`fs::write`] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fs::{read, write}
were stabilized in 1.26 as far as I can tell.
RELEASES.md
Outdated
---- | ||
- [Added “The Rustc book” into the official documentation.][49707] | ||
[“The Rustc book”] documents and teaches how to use the rustc compiler. | ||
- [All books are now seachable.][49623] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/seachable/searchable
RELEASES.md
Outdated
work.][49896] e.g. `::core::prelude::v1::StrExt::is_empty("")` will not | ||
compile, `"".is_empty()` will still compile. | ||
- [`Debug` output on `atomic::{AtomicBool, AtomicIsize, AtomicPtr, AtomicUsize}` | ||
will only printthe inner type.][48553] e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/printthe/print the
RELEASES.md
Outdated
- [`Debug` output on `atomic::{AtomicBool, AtomicIsize, AtomicPtr, AtomicUsize}` | ||
will only printthe inner type.][48553] e.g. | ||
`print!("{:?}", AtomicBool::new(true))` will print `true` | ||
not `AtomicBool(false)`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/false/true
RELEASES.md
Outdated
- [`[T]::rsplit`] | ||
- [`[T]::swap_with_slice`] | ||
- [`fs::read`] | ||
- [`fs::write`] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fs::{read, write}
where stabilized in 1.26
RELEASES.md
Outdated
- [A lot of methods for `[u8]`, `f32`, and `f64` previously only available in | ||
std are now available in core.][49896] | ||
- [`memchr::repeat_byte` is now optimised to have a reduced code | ||
size footprint.][50398] It will also be slightly faster on 64bit platforms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this item worth putting into the release note. The original PR doesn't have the relnote
label either. The perf isn't really impressive, just as the PR's title indicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release notes have never been exclusively pull requests with the relnotes label. I always like including optimisations as it is something a lot of people are interested in. If you feel strongly about its inclusion I'm fine with removing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do feel quite strongly because memchr::repeat_byte
isn't a public API.
We could say public APIs like <str>::{contains, find, rfind, matches, split, replace}
with a char
pattern becomes a bit faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely forgot that memchr is not in the public API. 😅
RELEASES.md
Outdated
[`Iterator::try_for_each`]: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.try_for_each | ||
[`NonNull::cast`]: https://doc.rust-lang.org/std/ptr/struct.NonNull.html#method.cast | ||
[`Option::filter`]: https://doc.rust-lang.org/std/option/enum.Option.html#method.filter | ||
[`String::replace_range`]: https://doc.rust-lang.org/beta/std/string/struct.String.html#method.replace_range |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link should not point to beta
RELEASES.md
Outdated
disable this feature ahead of time by setting any of the following `autobins`, | ||
`autobenches`, `autoexamples`, `autotests` to false. | ||
- [Cargo will now cache compiler information.][5359] This can be disabled by the | ||
`CARGO_CACHE_RUSTC_INFO` environment variable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify that you disable it by setting the env var to 0 (CARGO_CACHE_RUSTC_INFO=0
)
RELEASES.md
Outdated
be used as an identifer. | ||
- [The dyn syntax is now available.][49968] This syntax is equivalent to the | ||
bare `Trait` syntax, and should make it clearer when being used in tandem with | ||
`impl Trait`. Since it is equivalent to follow syntax has the same behaviour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean "the following syntax has" and to end with a colon there?
RELEASES.md
Outdated
} | ||
``` | ||
- [The maximum number for `repr(align(N))` is now 2²⁹.][50378] Previously you | ||
could enter higher numbers but they were not supported by LLVM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel we're missing a
512MB alignment ought to be enough for anybody
quote here
RELEASES.md
Outdated
to `Self`.][49630] | ||
- [`std::str::replace` now has the `#[must_use]` attribute][50177] to clarify | ||
that the operation isn't done in place. | ||
- [`ManuallyDrop::new` is now a constant function.][50148] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function is marked rustc_const_unstable
, so it's not stable yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it looks like that relnotes label was out of date.
RELEASES.md
Outdated
`readme`, and `repository` fields.][5386] | ||
- [Added the `--target-dir` optional argument.][5393] This allows you to specify | ||
a different directory than `target` for placing compilation artifacts. | ||
- [Added the `--out-dir` optional argument to `cargo-build`.][5203] Allowing you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--out-dir
is an unstable, nightly-only feature.
RELEASES.md
Outdated
will only print the inner type.][48553] e.g. | ||
`print!("{:?}", AtomicBool::new(true))` will print `true` | ||
not `AtomicBool(true)`. | ||
- [`?` can no longer be a seperator in macros.][49719] e.g. the following will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/seperator/separator
RELEASES.md
Outdated
`fn foo<#[lifetime_attr] 'a, #[type_attr] T: 'a>() {}` | ||
- [The `#[must_use]` attribute can now also be used on functions as well as | ||
types.][48925] It provides a lint that by default warns users when the | ||
return type is not being used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this read "the return value of the function"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer: ".. when the value, returned by the function, is not used." :)
☔ The latest upstream changes (presumably #51287) made this pull request unmergeable. Please resolve the merge conflicts. |
RELEASES.md
Outdated
|
||
Libraries | ||
--------- | ||
- [SIMD(Single Instruction Multiple Data) on x86/x86_64 is now stable.][49664] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you missed a space before (
By the way @Aaronepower, you should rebase this on top of master soonish, it would be bad being too late to backport this into beta. |
My current plan is to do the backport simultaneous with promotion to stable since this cannot fail if we run out of time |
e803025
to
54b5132
Compare
@pietroalbini Yeah, I was waiting on #51507 to be merged before I rebased in case somehow that also caused a merged conflict. It's rebased now. |
@bors r+ |
📌 Commit 46f74a3 has been approved by |
Updated RELEASES.md for 1.27.0 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md) r? @Mark-Simulacrum cc @rust-lang/release
[beta] Rollup backports * #51261: Updated RELEASES.md for 1.27.0 * #51591: Remove `?` macro separator compatibility note from 1.27 release notes r? @Mark-Simulacrum
Rendered
r? @Mark-Simulacrum
cc @rust-lang/release