Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RLS #50379

Merged
merged 1 commit into from
May 2, 2018
Merged

Update RLS #50379

merged 1 commit into from
May 2, 2018

Conversation

nrc
Copy link
Member

@nrc nrc commented May 1, 2018

r? @alexcrichton

Fixes RLS tests (broken by Cargo update) and enables nightly release

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 1, 2018
@nrc
Copy link
Member Author

nrc commented May 1, 2018

And Rustfmt too to fix tests there

@alexcrichton
Copy link
Member

@bors: r+ p=1

@bors
Copy link
Contributor

bors commented May 1, 2018

📌 Commit 6457241 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2018
@bors
Copy link
Contributor

bors commented May 1, 2018

⌛ Testing commit 6457241 with merge 5a662bf...

bors added a commit that referenced this pull request May 1, 2018
@bors
Auto merge of #50379 - nrc:update, r=alexcrichton
5a662bf 
Update RLS

r? @alexcrichton

Fixes RLS tests (broken by Cargo update) and enables nightly release
@bors
Copy link
Contributor

bors commented May 2, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 5a662bf to master...

@bors bors merged commit 6457241 into rust-lang:master May 2, 2018
@kennytm-githubbot
Copy link

📣 Toolstate changed by #50379!

Tested on commit 5a662bf.
Direct link to PR: #50379

🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-fail.

kennytm-githubbot added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 2, 2018
@kennytm-githubbot
📣 Toolstate changed by rust-lang/rust#50379!
7e7ced6 
Tested on commit rust-lang/rust@5a662bf.
Direct link to PR: <rust-lang/rust#50379>

🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-fail.
@Mark-Simulacrum
Copy link
Member

@nrc Is it intentional that tests appear to be failing on linux?

@nrc
Copy link
Member Author

nrc commented May 2, 2018

@nrc Is it intentional that tests appear to be failing on linux?

It is not :-(

@kennytm kennytm mentioned this pull request May 2, 2018
Closed
@nrc nrc mentioned this pull request May 3, 2018
Merged
@matklad matklad mentioned this pull request May 3, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request May 3, 2018
@kennytm
Rollup merge of rust-lang#50417 - matklad:pr-50379, r=alexcrichton
5976e8a 
Update Cargo

This should fix RLS

cc rust-lang#50379, rust-lang/cargo#5465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nrc @rust-highfive @alexcrichton @bors @kennytm-githubbot @Mark-Simulacrum