Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Basic Usage" to int min_value and max_value docs #46986

Merged
merged 1 commit into from
Dec 26, 2017

Conversation

nvzqz
Copy link
Contributor

@nvzqz nvzqz commented Dec 24, 2017

This adds "Basic Usage:" to the docs of min_value and max_value, which makes it consistent with docs of other integer methods.

@rust-highfive
Copy link
Collaborator

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Member

steveklabnik commented Dec 25, 2017 via email

@bors
Copy link
Contributor

bors commented Dec 25, 2017

📌 Commit c08a51c has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented Dec 25, 2017

⌛ Testing commit c08a51c with merge 5477c23a72670d296bf20879c11ac5313bce7f26...

@bors
Copy link
Contributor

bors commented Dec 25, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Dec 25, 2017

@bors retry #47002

@nvzqz
Copy link
Contributor Author

nvzqz commented Dec 25, 2017

@steveklabnik should all Examples be followed by "Basic Usage:" if they're not otherwise followed by any text?

@bors
Copy link
Contributor

bors commented Dec 26, 2017

⌛ Testing commit c08a51c with merge bf0ee965ba4a85e6c395ea7fc229e45d2ff3dd28...

@bors
Copy link
Contributor

bors commented Dec 26, 2017

💔 Test failed - status-travis

kennytm added a commit to kennytm/rust that referenced this pull request Dec 26, 2017
Add "Basic Usage" to int min_value and max_value docs

This adds "Basic Usage:" to the docs of `min_value` and `max_value`, which makes it consistent with docs of other integer methods.
bors added a commit that referenced this pull request Dec 26, 2017
Rollup of 8 pull requests

- Successful merges: #46928, #46930, #46933, #46939, #46940, #46943, #46979, #46986
- Failed merges:
@bors bors merged commit c08a51c into rust-lang:master Dec 26, 2017
@steveklabnik
Copy link
Member

@nvzqz https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md is the guidelines, which don't technically contain them. I actually thought that they did contain this, though, heh. It is a thing we do in stdlib sometimes.

@nvzqz nvzqz deleted the basic-usage branch December 26, 2017 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants