-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Basic Usage" to int min_value and max_value docs #46986
Conversation
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
Thanks so much!
@bors: r+ rollup
…On Sun, Dec 24, 2017 at 2:04 PM, Rust highfive robot < ***@***.***> wrote:
r? @sfackler <https://github.com/sfackler>
(rust_highfive has picked a reviewer for you, use r? to override)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#46986 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABsipELfFEaa0nrge1b2kvEA8BoSKAFks5tDqBIgaJpZM4RL_o2>
.
|
📌 Commit c08a51c has been approved by |
⌛ Testing commit c08a51c with merge 5477c23a72670d296bf20879c11ac5313bce7f26... |
💔 Test failed - status-travis |
@steveklabnik should all |
⌛ Testing commit c08a51c with merge bf0ee965ba4a85e6c395ea7fc229e45d2ff3dd28... |
💔 Test failed - status-travis |
Add "Basic Usage" to int min_value and max_value docs This adds "Basic Usage:" to the docs of `min_value` and `max_value`, which makes it consistent with docs of other integer methods.
@nvzqz https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md is the guidelines, which don't technically contain them. I actually thought that they did contain this, though, heh. It is a thing we do in stdlib sometimes. |
This adds "Basic Usage:" to the docs of
min_value
andmax_value
, which makes it consistent with docs of other integer methods.