rustbuild: distribute cargo-fmt alongside rustfmt #46031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Signed-off-by: Marc-Antoine Perennou <[email protected]>
kennytm
added
the
S-waiting-on-review
|
r? @nrc |
|
Thanks! Seems good to me, but r? @Mark-Simulacrum for the build system changes. |
Mark-Simulacrum
requested changes
Nov 20, 2017
src/bootstrap/dist.rs
Outdated
| let cargofmt = builder.ensure(tool::Cargofmt { | ||
| compiler: builder.compiler(stage, build.build), | ||
| target | ||
| }).expect("Rustfmt to build: toolstate is testing"); |
There was a problem hiding this comment.
Please change the expect statement here to "cargofmt" or something like that.
kennytm
added
S-waiting-on-bors
Signed-off-by: Marc-Antoine Perennou <[email protected]>
|
@bors: r=Mark-Simulacrum |
|
@Keruspe: 🔑 Insufficient privileges: Not in reviewers |
|
(I kind of expected that indeed, would have been surprised otherwise) |
|
@kennytm not waiting on bors yet, fwiw (wrt tags) |
|
@bors r+ |
|
📌 Commit b29a61e has been approved by |
|
|
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Nov 21, 2017
rustbuild: distribute cargo-fmt alongside rustfmt Not sure whether we want that nor if it's the right way to do so, but it feels quite weird to have rustfmt without cargo-fmt. Or are there other plans wrt that? What do you think @nrc ?
bors
added a commit
to rust-lang/rustup
that referenced
this pull request
Dec 6, 2017
Add rustfmt to the tools list r? @alexcrichton We should probably add something for cargo-fmt too once rust-lang/rust#46031 lands, but I'm not sure if we can just add it to the list or not, seeing as it is not its own component.
bors
added a commit
to rust-lang/rustup
that referenced
this pull request
Dec 6, 2017
Add rustfmt to the tools list r? @alexcrichton We should probably add something for cargo-fmt too once rust-lang/rust#46031 lands, but I'm not sure if we can just add it to the list or not, seeing as it is not its own component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure whether we want that nor if it's the right way to do so, but it feels quite weird to have rustfmt without cargo-fmt. Or are there other plans wrt that?
What do you think @nrc ?