Code

Implement arbitrary_self_types#45870

Code

Merged

bors merged 26 commits intorust-lang:masterrust-lang/rust:masterfrom mikeyhew:arbitrary_self_typesmikeyhew/rust:arbitrary_self_typesCopy head branch name to clipboardNov 12, 2017

+349-113

Commits

Commits on Nov 7, 2017

• add tests for the arbitrary_self_types, which won't pass yet

  mikeyhew

  committed
  edc8c76

  Copy full SHA for edc8c76

• initial implementation of arbitrary_self_types

  Show description for 497397a
  mikeyhew

  committed
  497397a

  Copy full SHA for 497397a

• Rewrote check_method_receiver and ExplicitSelf, got a borrow checker error

  Show description for 7dff08d
  mikeyhew

  committed
  7dff08d

  Copy full SHA for 7dff08d

• Fix the lifetime error in ExplicitSelf

  Show description for a3f5866
  mikeyhew

  committed
  a3f5866

  Copy full SHA for a3f5866

• Improve feature gate error, and return after emitting errors instead of looping forever

  mikeyhew

  committed
  9a592e6

  Copy full SHA for 9a592e6

• Fix some of the tests

  Show description for d03eb2c
  mikeyhew

  committed
  d03eb2c

  Copy full SHA for d03eb2c

• get the old error messages back

  Show description for aa0df3d
  mikeyhew

  committed
  aa0df3d

  Copy full SHA for aa0df3d

• Add arbitrary_self_types feature gate error to some tests

  mikeyhew

  committed
  6fd2156

  Copy full SHA for 6fd2156

• Update/improve documentation of ExpliciSelf

  mikeyhew

  committed
  0d739b5

  Copy full SHA for 0d739b5

• wrap error code in DiagnosticId::Error so it compiles

  mikeyhew

  committed
  1d29966

  Copy full SHA for 1d29966

Commits on Nov 8, 2017

• modify ExplicitSelf::determine to take an is_self_type predicate closure, instead of infcx

  mikeyhew

  committed
  0b27dcc

  Copy full SHA for 0b27dcc

• move ExplicitSelf to rustc::ty::util, and use it to implement object safety checks

  mikeyhew

  committed
  3902643

  Copy full SHA for 3902643

• normalize associated types in both self_ty and self_arg_ty

  Show description for 2369746
  mikeyhew

  committed
  2369746

  Copy full SHA for 2369746

• Switch from using At::eq to InferCtxt::can_eq and demand_eqtype_with_origin

  Show description for bbe755c
  mikeyhew

  committed
  bbe755c

  Copy full SHA for bbe755c

• add a NOTE comment to the object safety test so that it passes

  mikeyhew

  committed
  02ce3ac

  Copy full SHA for 02ce3ac

• Remove the error check that I think is redundant, and change the test error messages that I don't understand why they changed, so the tests pass

  mikeyhew

  committed
  e06cd31

  Copy full SHA for e06cd31

• tidy things up a bit

  mikeyhew

  committed
  0a3a46d

  Copy full SHA for 0a3a46d

• shorten line length for tidy

  mikeyhew

  committed
  0954e54

  Copy full SHA for 0954e54

• fix error message in arbitrary-self-types-not-object-safe test

  Show description for aa00f17
  mikeyhew

  committed
  aa00f17

  Copy full SHA for aa00f17

• update ui test to new error message

  mikeyhew

  committed
  7f8b003

  Copy full SHA for 7f8b003

Commits on Nov 9, 2017

• fix the bug in region_inference where constraint origins were being overwritten

  mikeyhew

  committed
  dcbb27a

  Copy full SHA for dcbb27a

• fixed all the compile-fail error messages

  Show description for 31d3783
  mikeyhew

  committed
  31d3783

  Copy full SHA for 31d3783

• update test/ui/static-lifetime.stderr with new error message

  mikeyhew

  committed
  c046fda

  Copy full SHA for c046fda

• add a comment explaining the bugfix to infer::region_inference::add_constraint

  mikeyhew

  committed
  5d170f0

  Copy full SHA for 5d170f0

• Don't emit the feature error if it's an invalid self type

  mikeyhew

  committed
  ddc21d5

  Copy full SHA for ddc21d5

• add run-pass tests

  mikeyhew

  committed
  77cd993

  Copy full SHA for 77cd993