Update the book on beta to fix the print button #45555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connects to #45552.
carols10cents
added
the
S-waiting-on-review
|
r=me on this; @alexcrichton @Mark-Simulacrum ; I always forget, can I just merge this kind of thing? We use bors for beta now, right? |
|
@steveklabnik Yes we do (but don't roll it up 😄). @bors r=steveklabnik |
|
📌 Commit 9d8320b has been approved by |
kennytm
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 27, 2017
Update the book on beta to fix the print button Connects to #45552. This does bring in changes to the text that we've made since beta branched, since we usually update the book just before beta goes to stable anyway, I didn't think this was a problem. If it is, I will happily make a branch of the book with just the print button fix and send in that instead! r? @steveklabnik
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #45552.
This does bring in changes to the text that we've made since beta branched, since we usually update the book just before beta goes to stable anyway, I didn't think this was a problem. If it is, I will happily make a branch of the book with just the print button fix and send in that instead!
r? @steveklabnik