Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the sidebar height #45212

Merged
merged 1 commit into from
Oct 26, 2017
Merged

Limit the sidebar height #45212

merged 1 commit into from
Oct 26, 2017

Conversation

GuillaumeGomez
Copy link
Member

The sidebar is now fixed, which means its scrolling is independent of the main page now.

r? @rust-lang/docs

@est31
Copy link
Member

est31 commented Oct 11, 2017

I think having multiple independently scrollable components is one of the negative things about doxygen.

@est31
Copy link
Member

est31 commented Oct 11, 2017

This would force me to move my mouse to the sidebar if I wanted to scroll inside it. Previously you can easily scroll with pgup/pgdown.

@QuietMisdreavus
Copy link
Member

Ehhhh, i'm +0 about this. I'm not sure it adds or detracts anything.

@kennytm
Copy link
Member

kennytm commented Oct 11, 2017

👍 if it is overflow: auto instead of overflow: scroll.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 11, 2017
Merged
@GuillaumeGomez GuillaumeGomez changed the title Fix the sidebar height Limit the sidebar height Oct 11, 2017
@kennytm kennytm added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-dev-tools-rustdoc labels Oct 13, 2017
@QuietMisdreavus QuietMisdreavus added I-nominated A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools and removed T-dev-tools-rustdoc labels Oct 17, 2017
@GuillaumeGomez
Copy link
Member Author

The @rust-lang/docs gave its go yesterday once the scrollbar: auto was done and passed tests. So here we go:

@bors: r=QuietMisdreavus rollup

@bors
Copy link
Contributor

bors commented Oct 25, 2017

📌 Commit 9ce41f2 has been approved by QuietMisdreavus

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Oct 25, 2017
kennytm added a commit to kennytm/rust that referenced this pull request Oct 25, 2017
@kennytm
Rollup merge of rust-lang#45212 - GuillaumeGomez:sidebar-fixed, r=Qui…
fc48893 
…etMisdreavus

Limit the sidebar height

The sidebar is now fixed, which means its scrolling is independent of the main page now.

r? @rust-lang/docs
@kennytm kennytm mentioned this pull request Oct 25, 2017
Merged
bors added a commit that referenced this pull request Oct 25, 2017
@bors
Auto merge of #45532 - kennytm:rollup, r=kennytm
e847f30 
Rollup of 7 pull requests

- Successful merges: #45059, #45212, #45398, #45483, #45496, #45508, #45526
- Failed merges:
@bors bors merged commit 9ce41f2 into rust-lang:master Oct 26, 2017
@GuillaumeGomez GuillaumeGomez deleted the sidebar-fixed branch October 26, 2017 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @est31 @QuietMisdreavus @kennytm @bors @steveklabnik