Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove the need for dumb-init #44110

Merged
merged 1 commit into from
Aug 27, 2017
Merged

Conversation

alexcrichton
Copy link
Member

Newer versions of Docker have a --init argument which spawns an init process
in the container, which we should be able to use everywhere now.

Newer versions of Docker have a `--init` argument which spawns an init process
in the container, which we should be able to use everywhere now.
@alexcrichton
Copy link
Member Author

r? @Mark-Simulacrum

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 27, 2017

📌 Commit ffe64a2 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Aug 27, 2017

⌛ Testing commit ffe64a2 with merge 47f53dabd958f2b37fbffa4f725c3697c9bffdd7...

@bors
Copy link
Contributor

bors commented Aug 27, 2017

💔 Test failed - status-appveyor

@Mark-Simulacrum
Copy link
Member

Presumably unrelated failure; we don't even use Docker on Windows currently.... @bors retry

[00:55:58] Dist mingw (i686-pc-windows-gnu)
[00:56:01] Error: failed to generate installer
[00:56:01] Caused by: failed to tar dir 'C:\projects\rust\build\tmp/dist\rust-mingw-nightly-i686-pc-windows-gnu\rust-m
[00:56:01] Caused by: Not enough storage is available to process this command. (os error 8)

@bors
Copy link
Contributor

bors commented Aug 27, 2017

⌛ Testing commit ffe64a2 with merge e266888...

bors added a commit that referenced this pull request Aug 27, 2017
ci: Remove the need for `dumb-init`

Newer versions of Docker have a `--init` argument which spawns an init process
in the container, which we should be able to use everywhere now.
@bors
Copy link
Contributor

bors commented Aug 27, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing e266888 to master...

@bors bors merged commit ffe64a2 into rust-lang:master Aug 27, 2017
@alexcrichton alexcrichton deleted the docker-init branch August 30, 2017 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants