-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustdoc: make major section headers self-links #43445
rustdoc: make major section headers self-links #43445
Conversation
The sidebar already has links to these h2's ids, but for convenience, the h2 itself should also be a link (retaining its present appearance). This should address most of rust-lang#24484.
(rust_highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Does not add IDs, just links to headlines.
Personally, I'd prefer to not link the entire headline, just the symbol (doesn't need to be § either, but makes sense), but I think this way it's easier to discover and actually use.
Indeed, thanks! @bors: r+ |
📌 Commit 09fc36e has been approved by |
…=GuillaumeGomez rustdoc: make major section headers self-links The sidebar already has links to these h2's ids, but for convenience, the h2 itself should also be a link (retaining its present appearance).  This should address most of #24484.
💔 Test failed - status-appveyor |
…=GuillaumeGomez rustdoc: make major section headers self-links The sidebar already has links to these h2's ids, but for convenience, the h2 itself should also be a link (retaining its present appearance).  This should address most of #24484.
☀️ Test successful - status-appveyor, status-travis |
The sidebar already has links to these h2's ids, but for convenience,
the h2 itself should also be a link (retaining its present appearance).
This should address most of #24484.