Allow remote testing remotely when TEST_DEVICE_ADDR is set
#43281
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
carols10cents
added
the
S-waiting-on-review
|
@bors: r+ Thanks! |
|
📌 Commit bbdbb65 has been approved by |
|
⌛ Testing commit bbdbb65 with merge a6e3e3e91e6faa2b52ce3ea0edef85b2f1494b65... |
|
💔 Test failed - status-travis |
|
@bors retry |
arielb1
added
S-waiting-on-bors
|
⌛ Testing commit bbdbb65 with merge b507bfec43f38de9e2682e697f56a6e1ae74b075... |
|
💔 Test failed - status-appveyor |
|
@bors: retry
…On Wed, Jul 19, 2017 at 4:11 AM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.3974>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#43281 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AaPN0I-EKic7RBit_PYwAWsVtmyMBQDmks5sPcgrgaJpZM4OZwFd>
.
--
You received this message because you are subscribed to the Google Groups
"rust-ops" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to ***@***.***
To post to this group, send email to ***@***.***
To view this discussion on the web visit https://groups.google.com/d/
msgid/rust-ops/rust-lang/rust/pull/43281/c316322734%40github.jparrowsec.cn
<https://groups.google.com/d/msgid/rust-ops/rust-lang/rust/pull/43281/c316322734%40github.jparrowsec.cn?utm_medium=email&utm_source=footer>
.
For more options, visit https://groups.google.com/d/optout.
|
|
@nagbot-rs: 🔑 Insufficient privileges: and not in try users |
|
@bors: retry |
Allow remote testing remotely when `TEST_DEVICE_ADDR` is set Remote testing was added in #41268, but at the moment it's only enabled if QEMU is also available or we're testing Android. This patch also allows remote testing if the environment variable `TEST_DEVICE_ADDR` is set, as required by `remote-test-client` [[1](https://github.com/rust-lang/rust/blob/master/src/tools/remote-test-client/src/main.rs#L28), [2](https://github.com/rust-lang/rust/blob/master/src/tools/remote-test-client/src/main.rs#L61)]
|
☀️ Test successful - status-appveyor, status-travis |
Remote testing was added in #41268, but at the moment it's only enabled if QEMU is also available or we're testing Android. This patch also allows remote testing if the environment variable
TEST_DEVICE_ADDRis set, as required byremote-test-client[1, 2]