Various minor cleanups to rustbuild #43042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
added
the
S-waiting-on-review
|
@bors: r+ Nice cleanups! |
|
📌 Commit e04754b has been approved by |
Mark-Simulacrum
added
S-waiting-on-bors
|
@bors rollup |
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jul 4, 2017
…r=alexcrichton Various minor cleanups to rustbuild This is work I did before the migration to the new rustbuild. I'd prefer to land this first, before my other PR, to make the diff a little clearer. r? @alexcrichton
|
I think I broke something, need to investigate.. @bors r- |
Rename Build.{cargo, rustc} to {initial_cargo, initial_rustc}.
This makes later negation much easier to interpret.
Prevents accidental mistakes in not using the right verbosity by going to only config or flags.
Mark-Simulacrum
force-pushed
the
rustbuild-cleanup
branch
from
e04754b to
1654a2f
Compare
|
Ah, found the problem.. I had changed what targets/hosts we find cc/cxx for to be only the ones passed on the command line, but I guess that's not enough. @bors r=alexcrichton |
|
📌 Commit 1654a2f has been approved by |
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Jul 4, 2017
…r=alexcrichton Various minor cleanups to rustbuild This is work I did before the migration to the new rustbuild. I'd prefer to land this first, before my other PR, to make the diff a little clearer. r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work I did before the migration to the new rustbuild. I'd prefer to land this first, before my other PR, to make the diff a little clearer.
r? @alexcrichton