-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use multiline note for trait suggestion #42383
Conversation
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
= help: items from traits can only be used if the trait is implemented and in scope; the following traits define an item `is_empty`, perhaps you need to implement one of them: | ||
candidate #1: `std::iter::ExactSizeIterator` | ||
candidate #2: `core::slice::SliceExt` | ||
candidate #3: `core::str::StrExt` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we should rephrase this to something more like this:
= help: items from traits can only be used if the trait is implemented and in scope
= note: the following traits define an item `is_empty`, perhaps you need to implement one?
`std::iter::ExactSizeIterator`
`core::slice::SliceExt`
`core::str::StrExt`
Travis failure:
r+ with that fixed. |
fde6df0
to
397972f
Compare
@bors r=arielb1 |
📌 Commit 397972f has been approved by |
Use multiline note for trait suggestion
☀️ Test successful - status-appveyor, status-travis |
No description provided.