Feature/memory #4145
Closed
Feature/memory #4145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disabled copying. * Added const where appropiate.
1) indexed_list no longer has virtual methods. It's not actually subclassed and there is very rarely good reason to subclass collection classes. 2) Added a virtual dtor to indexed_list_object which is intended to be subclassed. This allows derived dtors to be called if the object is deleted with a indexed_list_object*.
|
Nice cleanup. |
|
Done |
|
The windows bot has a problem with a format specifier: http://buildbot.rust-lang.org/builders/try-win/builds/146/steps/compile/logs/stdio |
|
Yeah, I was worried that would happen. %zu might work. If not that, casting arg 3 to a long int. I don't have access to a Windows box able to build rust tho. |
|
Merged. Thanks. |
calebcartwright
pushed a commit
to calebcartwright/rust
that referenced
this pull request
Oct 20, 2021
Servo has used this since forever, and it'd be useful to be able to use rustfmt stable there so that we can use the same rustfmt version in both Firefox and Servo. Feel free to close this if there's any reason it shouldn't be done.
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Jan 26, 2025
Automatic Rustup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was looking at why my server leaked memory like a sieve. Pretty sure it is because cycles of managed pointers are not collected until task cleanup.
Along the way towards discovering this I made some small improvements to the runtime code. For the most part they are fixes to make it harder to misuse the classes.