allow interner cache to be shared across parsers (#3699) #3700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code change looks good to me. I don't fully remember why the original code failed rather than returning the existing interner; I guess I figured that interner creation was (and ought to be) statically guaranteed to happen in only one place. |
catamorphism
added a commit
that referenced
this pull request
Oct 9, 2012
allow interner cache to be shared across parsers (#3699)
|
Thanks! |
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Jun 29, 2024
./miri: nicer error when building miri-script fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is to potentially fix (#3699). It allows the parser interner cache to be shared between multiple parsers on the same thread. I'm not quite sure what the consequences of this are, but most of the tests pass on my laptop (the failures already exist on incoming so I believe they are unrelated).
cargo install mongrel2works as well.