Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jemalloc to include a fix for startup issues on OSX 10.12 #34719

Merged
merged 1 commit into from
Jul 9, 2016

Conversation

glandium
Copy link
Contributor

@glandium glandium commented Jul 8, 2016

This fixes jemalloc/jemalloc#140 in the version used by the rust compiler.

Fixes #34674

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@glandium
Copy link
Contributor Author

glandium commented Jul 8, 2016

Cloning into 'src/jemalloc'...
fatal: reference is not a tree: e058ca661692a8d01f8cf9d35939dfe3105ce968

Obviously it's not merged yet... this will need a rebuild after it's merged.

@alexcrichton
Copy link
Member

@bors: r+ 3fd0387

Thanks @glandium! I can only imagine how fun this must have been to find and fix...

@alexcrichton
Copy link
Member

Also, nominating for beta as this seems like it's better to get out there sooner rather than later (e.g. 1.11 instead of 1.12)

@alexcrichton alexcrichton added beta-nominated Nominated for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jul 8, 2016
@Manishearth
Copy link
Member

fails travis

@bors
Copy link
Contributor

bors commented Jul 9, 2016

⌛ Testing commit 3fd0387 with merge 24d51f9...

bors added a commit that referenced this pull request Jul 9, 2016
Update jemalloc to include a fix for startup issues on OSX 10.12

This fixes jemalloc/jemalloc#140 in the version used by the rust compiler.

Fixes #34674
@alexcrichton
Copy link
Member

Discussed at libs triage today we decided to accept this for a backport to beta

@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jul 19, 2016
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jul 19, 2016
@glandium glandium deleted the issue34674 branch April 2, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
7 participants