Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#24355 Update to latest version of the SourceCodePro fonts #34120

Closed
wants to merge 1 commit into from

Conversation

ipsi
Copy link

@ipsi ipsi commented Jun 6, 2016

As per issue #24355, the funny looking ampersands in the docs are annoying me (and others), so I'm adding the latest versions of the fonts, pulled from Adobe Fonts, plus the latest LICENCE file for the fonts (appears to have added a space).

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@ipsi
Copy link
Author

ipsi commented Jun 6, 2016

Hmmm - does not seem to actually solve the problem (clearly going mad...). Closing pull request.

@ipsi ipsi closed this Jun 6, 2016
@retep998
Copy link
Member

retep998 commented Jun 7, 2016

The issue is your local fonts need updating. The ones that are in the repo are fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants