Book: in beginner guide change irc channel #rust → #rust-beginners

[tyoc213]

#32585 r? @alexcrichton

I also would like to add the reference on the first README.md

Some like

 most popular channel is [#rust], a venue for general discussion about
-Rust, and a good place to ask for help.
+Rust. And a good place to ask for help would be [#rust-beginners].

 [IRC]: https://en.wikipedia.org/wiki/Internet_Relay_Chat
 [#rust]: irc://irc.mozilla.org/rust
+[#rust-beginners]: irc://irc.mozilla.org/rust-beginners

So In the first page would be the two options for #rust or #rust-beginners

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[steveklabnik]

👍 from me

[tyoc213]

So, I will add the change to the README.md or it should only be the change on the book?

If it where the change to the readme, the text in the first comment would be the correct wording?

[alexcrichton]

Sounds good to me to change the README as well! Perhaps the #rust channel could also still be mentioned here along with #rust-beginners?

[tyoc213]

Just added the info to the README and updated the part in getting-started for #rust and #rust-beginners

[alexcrichton]

This second clause of "which we can access through mibbit" can probably be dropped as it was already mentioned before, otherwise looks good to me!

[tyoc213]

Well, the only problem I see now, is that I see only my last commit as the git user here, should I replace my user in those commits? with something like change email? or should I leave it like that?

---

Well I didn't use the method above, but instead git rebase -i HEAD~4 and amend the author, should I force the push on my branch so the commits have the correct user email?

[steveklabnik]

@tyoc213 yeah, just force push those

[tyoc213]

Done, thanks!

[alexcrichton]

@bors: r+ 9094935

[steveklabnik]

@bors: rollup

On Mar 31, 2016, 10:32 -0700, Alex [email protected], wrote:

@bors(https://github.com/bors): r+9094935(9094935)

—
You are receiving this because you commented.
Reply to this email directly orview it on GitHub(#32622 (comment))