Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: The data-layout field is no longer required in custom targets #32375

Merged
merged 1 commit into from
Mar 20, 2016
Merged

docs: The data-layout field is no longer required in custom targets #32375

merged 1 commit into from
Mar 20, 2016

Conversation

phil-opp
Copy link
Contributor

The data-layout field is no longer required. It was made optional in 958d563.

The os field is always required.

Related to #31367

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jroesch (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@japaric
Copy link
Member

japaric commented Mar 20, 2016

Could you change 'data-layout' for 'os'? That one is also a required field.

@phil-opp
The data-layout field is no longer required, but the os field is
9532602 
The `data-layout` field  was made optional in 958d563. The `os` field is always required.
@phil-opp
Copy link
Contributor Author

Done. It seems like the list of required items is complete now.

@japaric
Copy link
Member

japaric commented Mar 20, 2016

Done. It seems like the list of required items is complete now.

Yes, thank you!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 20, 2016

📌 Commit 9532602 has been approved by japaric

@bors
Copy link
Contributor

bors commented Mar 20, 2016

⌛ Testing commit 9532602 with merge 978bc07...

bors added a commit that referenced this pull request Mar 20, 2016
@bors
Auto merge of #32375 - phil-opp:patch-1, r=japaric
978bc07 
docs: The `data-layout` field is no longer required in custom targets

The `data-layout` field is no longer required. It was made optional in 958d563.

The `os` field is always required.

Related to #31367
@bors bors mentioned this pull request Mar 20, 2016
Merged
@bors
Copy link
Contributor

bors commented Mar 20, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-64-x-armhf, auto-linux-64-x-armsf, auto-linux-64-x-freebsd, auto-linux-64-x-netbsd, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-mac-ios-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild

@bors bors merged commit 9532602 into rust-lang:master Mar 20, 2016
@phil-opp phil-opp deleted the patch-1 branch March 20, 2016 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jroesch jroesch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@phil-opp @rust-highfive @japaric @bors @jroesch