Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make clean support to rustbuild #31591

Merged
merged 2 commits into from
Feb 13, 2016

Conversation

alexcrichton
Copy link
Member

At the same time also touch up the job management on Windows to be a little more resilient to failure.

Also add a `clean` target for the makefiles to blow away everything related to
the build. Note that this specifically does not tamper with:

* the LLVM build directory
* the directory of the bootstrap system
* the cached downloads of cargo/rustc
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Feb 12, 2016

r=me with nits

The build bots already use job objects, and they don't support nested job
objects, and we shouldn't entirely bail out in this case anyway!
@alexcrichton alexcrichton force-pushed the make-clean-with-rustbuild branch from cd8a86c to 07638b9 Compare February 12, 2016 18:40
@alexcrichton
Copy link
Member Author

@bors: r=brson 07638b9

bors added a commit that referenced this pull request Feb 13, 2016
At the same time also touch up the job management on Windows to be a little more resilient to failure.
@bors
Copy link
Contributor

bors commented Feb 13, 2016

⌛ Testing commit 07638b9 with merge bc91927...

@bors bors merged commit 07638b9 into rust-lang:master Feb 13, 2016
@alexcrichton alexcrichton deleted the make-clean-with-rustbuild branch February 15, 2016 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants