-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly output links for primitive types which enclose their contents #31121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(rust_highfive has picked a reviewer for you, use r? to override) |
⌛ Testing commit 9a80bc8 with merge 6dd69d8... |
💔 Test failed - auto-linux-64-nopt-t |
@bors r=alexcrichton |
📌 Commit 5a26a52 has been approved by |
bors
added a commit
that referenced
this pull request
Jan 23, 2016
We currently nest `<a>` tags which is doubleplusungood. So, for example, `(u8, u8)` will show up with the left paren linked to the tuple primitive page, and the right paren unlinked, which looks ugly.
This was referenced Jan 28, 2016
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jan 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently nest
<a>
tags which is doubleplusungood. So, for example,(u8, u8)
will show upwith the left paren linked to the tuple primitive page, and the right paren unlinked, which looks ugly.