Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly output links for primitive types which enclose their contents #31121

Merged
merged 2 commits into from
Jan 23, 2016

Conversation

Manishearth
Copy link
Member

We currently nest <a> tags which is doubleplusungood. So, for example, (u8, u8) will show up
with the left paren linked to the tuple primitive page, and the right paren unlinked, which looks ugly.

@rust-highfive
Copy link
Collaborator

r? @steveklabnik

(rust_highfive has picked a reviewer for you, use r? to override)

@Manishearth
Copy link
Member Author

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+ 9a80bc8

@bors
Copy link
Contributor

bors commented Jan 23, 2016

⌛ Testing commit 9a80bc8 with merge 6dd69d8...

@bors
Copy link
Contributor

bors commented Jan 23, 2016

💔 Test failed - auto-linux-64-nopt-t

@Manishearth
Copy link
Member Author

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Jan 23, 2016

📌 Commit 5a26a52 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jan 23, 2016

⌛ Testing commit 5a26a52 with merge 1571c69...

bors added a commit that referenced this pull request Jan 23, 2016
We currently nest `<a>` tags which is doubleplusungood. So, for example, `(u8, u8)` will show up
with the left paren linked to the tuple primitive page, and the right paren unlinked, which looks ugly.
@bors bors merged commit 5a26a52 into rust-lang:master Jan 23, 2016
Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 29, 2016
@Manishearth Manishearth deleted the prim-link branch December 2, 2016 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants