Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in std::fmt docs #30968

Closed
wants to merge 1 commit into from
Closed

Fix typo in std::fmt docs #30968

wants to merge 1 commit into from

Conversation

boblehest
Copy link
Contributor

Text says two options, but three options are listed. Go to DEFCON 1!

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against tmp. Please double check that you specified the right target!

@apasel422
Copy link
Contributor

@bors: r+ rollup

Thanks!

@bors
Copy link
Contributor

bors commented Jan 17, 2016

📌 Commit 46c23e8 has been approved by apasel422

@apasel422
Copy link
Contributor

@bors: r-

Why is this against the tmp branch?

@boblehest
Copy link
Contributor Author

Oops. I'm so used to it happening against the master branch by default, I guess I forgot to actually check! Thanks for catching that. :)

Edit: Oh, rust-highfive caught it above, I didn't see that comment at first.

@boblehest boblehest closed this Jan 17, 2016
Manishearth added a commit to Manishearth/rust that referenced this pull request Jan 18, 2016
Original: rust-lang#30968 (My first PR was targeting the wrong branch)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants