-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix capitalization inside sentense #28283
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Oh, words after colons in English are capitalized in some cases. Didn't knew, sorry! :) |
Is that true? I actually would have thought this patch was correct. |
@steveklabnik I found that in some cases words after colons may be capitalized, e.g. one of discussions: https://english.stackexchange.com/questions/6931/capitalization-after-colon If you think more correct way would be not capitalize (looks like it's more style/culture related, than forced by rules), please reopen this PR. Also, I've found at least one more example of capitalized word after colon in the Rust documentation. |
@bors: r+ rollup |
📌 Commit b1e8007 has been approved by |
Please send me another PR to fix it :) Thanks so much for all of these fixes. |
⌛ Testing commit b1e8007 with merge bd61136... |
💔 Test failed - auto-win-gnu-64-opt |
@bors: retry On Mon, Sep 7, 2015 at 12:25 PM, bors [email protected] wrote:
|
r? @steveklabnik