Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix capitalization inside sentense #28283

Merged
merged 1 commit into from
Sep 9, 2015
Merged

fix capitalization inside sentense #28283

merged 1 commit into from
Sep 9, 2015

Conversation

rutsky
Copy link
Contributor

@rutsky rutsky commented Sep 7, 2015

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rutsky
Copy link
Contributor Author

rutsky commented Sep 7, 2015

Oh, words after colons in English are capitalized in some cases. Didn't knew, sorry! :)

@rutsky rutsky closed this Sep 7, 2015
@steveklabnik
Copy link
Member

Is that true? I actually would have thought this patch was correct.

@rutsky
Copy link
Contributor Author

rutsky commented Sep 7, 2015

@steveklabnik I found that in some cases words after colons may be capitalized, e.g. one of discussions: https://english.stackexchange.com/questions/6931/capitalization-after-colon

If you think more correct way would be not capitalize (looks like it's more style/culture related, than forced by rules), please reopen this PR.

Also, I've found at least one more example of capitalized word after colon in the Rust documentation.

@steveklabnik steveklabnik reopened this Sep 7, 2015
@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Sep 7, 2015

📌 Commit b1e8007 has been approved by steveklabnik

@steveklabnik
Copy link
Member

Also, I've found at least one more example of capitalized word after colon in the Rust documentation.

Please send me another PR to fix it :) Thanks so much for all of these fixes.

@bors
Copy link
Contributor

bors commented Sep 7, 2015

⌛ Testing commit b1e8007 with merge bd61136...

@bors
Copy link
Contributor

bors commented Sep 7, 2015

💔 Test failed - auto-win-gnu-64-opt

@alexcrichton
Copy link
Member

@bors: retry

On Mon, Sep 7, 2015 at 12:25 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-gnu-64-opt
http://buildbot.rust-lang.org/builders/auto-win-gnu-64-opt/builds/1332


Reply to this email directly or view it on GitHub
#28283 (comment).

Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 9, 2015
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 9, 2015
bors added a commit that referenced this pull request Sep 9, 2015
@bors bors merged commit b1e8007 into rust-lang:master Sep 9, 2015
bors added a commit that referenced this pull request Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants