Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation IP ranges: e.g., 192.0.2.* instead of 192.*.2.*. #27038

Merged
merged 1 commit into from
Jul 20, 2015

Conversation

ktossell
Copy link
Contributor

Ipv4Addr::is_documentation() matches 513 /24 blocks when it should only match 3.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@ktossell ktossell force-pushed the narrow_doc_ip_ranges branch 2 times, most recently from 6fa5c99 to dd9718f Compare July 14, 2015 16:03
@alexcrichton
Copy link
Member

Thanks! Could you add a test for this as well?

@ktossell
Copy link
Contributor Author

@alexcrichton I added some more cases to the ipv4_properties test. It now checks all three documentation ranges, and it verifies that non-zero values are excluded for the fields that used to be _. fb68fb1

@alexcrichton
Copy link
Member

Thanks! Could you also squash these down? Other than that r=me.

@ktossell ktossell force-pushed the narrow_doc_ip_ranges branch from 4fad5bc to 6e5f960 Compare July 16, 2015 18:42
@ktossell
Copy link
Contributor Author

Sure, squashed and rebased.

@alexcrichton
Copy link
Member

@bors: r+ 6e5f960

Thanks!

@Manishearth
Copy link
Member

bors added a commit that referenced this pull request Jul 17, 2015
@bors
Copy link
Contributor

bors commented Jul 17, 2015

⌛ Testing commit 6e5f960 with merge 06b52fe...

@Manishearth
Copy link
Member

@bors r- force

(fails tests)

@bors
Copy link
Contributor

bors commented Jul 17, 2015

⛄ The build was interrupted to prioritize another pull request.

Add Ipv4Addr tests to verify doc address checking.
@ktossell ktossell force-pushed the narrow_doc_ip_ranges branch from 6e5f960 to d45c22b Compare July 19, 2015 00:30
@ktossell
Copy link
Contributor Author

Fixed the test.

@alexcrichton
Copy link
Member

@bors: r+ d45c22b

@bors
Copy link
Contributor

bors commented Jul 20, 2015

⌛ Testing commit d45c22b with merge 5e3b756...

bors added a commit that referenced this pull request Jul 20, 2015
Ipv4Addr::is_documentation() matches 513 /24 blocks when it should only match 3.
@bors bors merged commit d45c22b into rust-lang:master Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants