-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix documentation IP ranges: e.g., 192.0.2.* instead of 192.*.2.*. #27038
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
6fa5c99
to
dd9718f
Compare
Thanks! Could you add a test for this as well? |
@alexcrichton I added some more cases to the |
Thanks! Could you also squash these down? Other than that r=me. |
4fad5bc
to
6e5f960
Compare
Sure, squashed and rebased. |
@bors: r+ 6e5f960 Thanks! |
⌛ Testing commit 6e5f960 with merge 06b52fe... |
@bors r- force (fails tests) |
⛄ The build was interrupted to prioritize another pull request. |
Add Ipv4Addr tests to verify doc address checking.
6e5f960
to
d45c22b
Compare
Fixed the test. |
Ipv4Addr::is_documentation() matches 513 /24 blocks when it should only match 3.
Ipv4Addr::is_documentation() matches 513 /24 blocks when it should only match 3.