Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax: move ast_map to librustc. #26141

Merged
merged 1 commit into from
Jun 10, 2015
Merged

syntax: move ast_map to librustc. #26141

merged 1 commit into from
Jun 10, 2015

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Jun 9, 2015

Gets libsyntax one step closer to running on stable (see #24518).
Closes #24757, erickt's previous attempt at this.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 9, 2015

📌 Commit cdc182a has been approved by nikomatsakis

@alexcrichton alexcrichton added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 9, 2015
@eddyb
Copy link
Member Author

eddyb commented Jun 9, 2015

@bors r=nikomatsakis

@bors
Copy link
Contributor

bors commented Jun 9, 2015

📌 Commit 76eaed4 has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented Jun 10, 2015

⌛ Testing commit 76eaed4 with merge a10aec6...

bors added a commit that referenced this pull request Jun 10, 2015
Gets libsyntax one step closer to running on stable (see #24518).
Closes #24757, erickt's previous attempt at this.
@bors
Copy link
Contributor

bors commented Jun 10, 2015

💔 Test failed - auto-linux-32-opt

@eddyb
Copy link
Member Author

eddyb commented Jun 10, 2015

@bors retry

bors added a commit that referenced this pull request Jun 10, 2015
Gets libsyntax one step closer to running on stable (see #24518).
Closes #24757, erickt's previous attempt at this.
@bors
Copy link
Contributor

bors commented Jun 10, 2015

⌛ Testing commit 76eaed4 with merge d8a9570...

@bors
Copy link
Contributor

bors commented Jun 10, 2015

💔 Test failed - auto-mac-32-opt

@eddyb
Copy link
Member Author

eddyb commented Jun 10, 2015

@bors retry

@bors
Copy link
Contributor

bors commented Jun 10, 2015

@Manishearth
Copy link
Member

Would it be worth/possible moving this to librustc_ast_map? Every bit helps :)

@eddyb
Copy link
Member Author

eddyb commented Jun 10, 2015

@Manishearth it wouldn't help much because librustc depends on it. Most of the parallelism in building rustc starts after librustc.

@Manishearth
Copy link
Member

Ah. Might it be reasonable to have some parallel crates in between syntax and rustc?

The way I see it, we can fan out after syntax, converge on rustc, and then fan out into the rustc_*s. Not a big win, but still could be a win.

@bors bors merged commit 76eaed4 into rust-lang:master Jun 10, 2015
@eddyb eddyb deleted the ast_map branch June 10, 2015 18:42
@erickt
Copy link
Contributor

erickt commented Jun 10, 2015

thanks @eddyb! I'm still catching up from my vacation, and haven't gotten around to fixing my PRs yet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants