-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syntax: move ast_map to librustc. #26141
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ |
📌 Commit cdc182a has been approved by |
@bors r=nikomatsakis |
📌 Commit 76eaed4 has been approved by |
💔 Test failed - auto-linux-32-opt |
@bors retry |
⌛ Testing commit 76eaed4 with merge d8a9570... |
💔 Test failed - auto-mac-32-opt |
@bors retry |
⚡ Previous build results for auto-linux-32-nopt-t, auto-linux-64-nopt-t, auto-linux-64-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt are reusable. Rebuilding only auto-linux-32-opt, auto-linux-64-x-android-t, auto-mac-32-opt... |
Would it be worth/possible moving this to |
@Manishearth it wouldn't help much because librustc depends on it. Most of the parallelism in building rustc starts after librustc. |
Ah. Might it be reasonable to have some parallel crates in between syntax and rustc? The way I see it, we can fan out after syntax, converge on rustc, and then fan out into the rustc_*s. Not a big win, but still could be a win. |
thanks @eddyb! I'm still catching up from my vacation, and haven't gotten around to fixing my PRs yet :) |
Gets libsyntax one step closer to running on stable (see #24518).
Closes #24757, erickt's previous attempt at this.