Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear cached landing pads before generating a call. #26062

Merged
merged 1 commit into from
Jun 17, 2015
Merged

Clear cached landing pads before generating a call. #26062

merged 1 commit into from
Jun 17, 2015

Conversation

eefriedman
Copy link
Contributor

Using the wrong landing pad has obvious bad effects, like dropping a value
twice.

Testcase written by Alex Crichton.

Fixes #25089.

@eefriedman
Clear cached landing pads before generating a call.
a1d2eb8 
Using the wrong landing pad has obvious bad effects, like dropping a value
twice.

Testcase written by Alex Crichton.

Fixes rust-lang#25089.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Nominating for beta backporting as well

@alexcrichton alexcrichton added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 7, 2015
@nrc
Copy link
Member

nrc commented Jun 7, 2015

r? @pnkfelix

@rust-highfive rust-highfive assigned pnkfelix and unassigned nrc Jun 7, 2015
@alexcrichton alexcrichton added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 9, 2015
@eefriedman
Copy link
Contributor Author

Ping?

@alexcrichton alexcrichton mentioned this pull request Jun 15, 2015
Closed
@nrc
Copy link
Member

nrc commented Jun 15, 2015

ping @pnkfelix for review

@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jun 17, 2015

📌 Commit a1d2eb8 has been approved by nikomatsakis

@nikomatsakis
Copy link
Contributor

(swiped this from @pnkfelix)

@bors
Copy link
Contributor

bors commented Jun 17, 2015

⌛ Testing commit a1d2eb8 with merge 6065bed...

bors added a commit that referenced this pull request Jun 17, 2015
@bors
Auto merge of #26062 - eefriedman:cleanup-cached, r=nikomatsakis
6065bed 
Using the wrong landing pad has obvious bad effects, like dropping a value
twice.

Testcase written by Alex Crichton.

Fixes #25089.
@bors
Copy link
Contributor

bors commented Jun 17, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt

@bors bors merged commit a1d2eb8 into rust-lang:master Jun 17, 2015
@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jun 18, 2015
@nikomatsakis
Copy link
Contributor

triage: beta-accepted -- this seems like a very small change, simple enough to backport, and clearing cached landing pads is very low risk (just means less efficient code gen)

@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 18, 2015
@brson
Copy link
Contributor

brson commented Jun 18, 2015

This has already landed on beta.

@brson
Copy link
Contributor

brson commented Jun 18, 2015

@brson No it hasn't dummy.

@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 18, 2015
@brson brson mentioned this pull request Jun 18, 2015
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@eefriedman @rust-highfive @alexcrichton @nrc @nikomatsakis @bors @brson @pnkfelix