Remove #[static_assert] #24910
Merged
Remove #[static_assert] #24910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
👍 |
|
Brought this up in the meeting, RFC incoming |
|
Filed: rust-lang/rfcs#1096 |
|
☔ The latest upstream changes (presumably #25175) made this pull request unmergeable. Please resolve the merge conflicts. |
This was always a weird feature, and isn't being used in the compiler. Static assertions should be done better than this. This implements RFC rust-lang#1096. Fixes rust-lang#13951 Fixes rust-lang#23008 Fixes rust-lang#6676 This is behind a feature gate, but that's still a [breaking-change]
steveklabnik
force-pushed
the
remove_static_assert
branch
from
c446e30 to
5235065
Compare
|
@nikomatsakis I have rebased this PR. |
bors
added a commit
that referenced
this pull request
Jun 3, 2015
This was always a weird feature, and isn't being used in the compiler. Static assertions should be done better than this. Fixes #13951 Fixes #23008 Fixes #6676 This is behind a feature gate, but that's still a [breaking-change] (It's not entirely clear to me that this should or shouldn't have an RFC, but if it does, I'm fine blocking on such a thing.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was always a weird feature, and isn't being used in the compiler.
Static assertions should be done better than this.
Fixes #13951
Fixes #23008
Fixes #6676
This is behind a feature gate, but that's still a
[breaking-change]
(It's not entirely clear to me that this should or shouldn't have an RFC, but if it does, I'm fine blocking on such a thing.)