Eschew arena::Arena in variance.rs #21987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance analysis. (The code was not using the main feature of Arena in the first place, since all of the `alloc` calls were on the same type.
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
spawned off of #21972. |
|
@bors r+ 50c674 rollup |
|
(also, anyone can review this. It is a trivial refactoring from one API to another.) |
|
@huonw you dropped a 2 at the end of that hash, does bors still catch that? |
|
@reem (apparently not!) |
|
🙀 You have the wrong number! Please try again with |
|
(Like that, I guess.) |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 6, 2015
…nalysis, r=huonw Use a TypedArena rather than an Arena for the backing storage of variance analysis. (The code was not using the main feature of Arena in the first place, since all of the `alloc` calls were on the same type.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a TypedArena rather than an Arena for the backing storage of variance analysis.
(The code was not using the main feature of Arena in the first place, since all of the
alloccalls were on the same type.)