Misc Stabilization for collections #20053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @gankro |
| /// | ||
| /// ``` | ||
| pub fn top<'a>(&'a self) -> Option<&'a T> { | ||
| pub fn peek<'a>(&'a self) -> Option<&'a T> { |
|
Just the one nit. (I found one so that means I did a good job, right?) Also as an aside I just realized that I left Bitv::set to be stabilized, which I don't think I ultimately wanted. I thought I had changed that in the RFC, but I guess not? |
|
It's certainly left to be stabilized, but the language is quite tentative, e.g. Anyway, I added that missing stability marker. |
|
Needs a rebase |
|
Oof...Currently doing a build...I'll get this rebased ASAP! |
This commit: *Renames `BinaryHeap::top` to `BinaryHeap::peek` *Stabilizes `front/back/front_mut/back_mut` in `DList` and `RingBuf` *Stabilizes `swap` in `RingBuf` Because of the method renaming, this is a [breaking-change].
|
Rebased! cc @alexcrichton @gankro |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 22, 2014
This pull request: *Renames `BinaryHeap::top` to `BinaryHeap::peek` *Stabilizes `front/back/front_mut/back_mut` in `DList` and `RingBuf` *Stabilizes `swap` in `RingBuf` in accordance with rust-lang/rfcs#509. Note that this PR does not address `Bitv::{get,set}` or HashMap's iterators, nor does it move `std::vec` to `std::collections::vec`, all of which still need to be done. Because of the method renaming, this is a [breaking-change].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
*Renames
BinaryHeap::toptoBinaryHeap::peek*Stabilizes
front/back/front_mut/back_mutinDListandRingBuf*Stabilizes
swapinRingBufin accordance with rust-lang/rfcs#509.
Note that this PR does not address
Bitv::{get,set}or HashMap's iterators, nor does it movestd::vectostd::collections::vec, all of which still need to be done.Because of the method renaming, this is a [breaking-change].