Clean up collections::binary_heap
#19967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.data.push(item); | ||
| let new_len = self.len() - 1; | ||
| self.siftup(0, new_len); |
There was a problem hiding this comment.
...why is it even called _new__len?
|
Awesome, this looks great modulo my two nits! |
|
Nits addressed. |
| match self.data.get_mut(0) { | ||
| None => return item, | ||
| Some(top) => | ||
| if *top > item { |
There was a problem hiding this comment.
Normally I would put the if itself on the same line to reduce the indentation level, but in this case I think it's fine like this.
|
Variable naming and indentation addressed. |
bors
added a commit
that referenced
this pull request
Dec 19, 2014
Clean up `collections::binary_heap` Reviewed-by: Gankro
bors
referenced
this pull request
Dec 19, 2014
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 21, 2014
Just a few simplifications and a missing `assert!`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few simplifications and a missing
assert!.