Guide: edit Generics and Traits sections #19625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before reading this, I just want to say that I'm wary of copy-editing that changes the tone significantly. I've gotten a lot of positive feedback on how different the Guide is from other programming texts, and I'd like to keep it that way. On to the review! 🎊 |
| This is really unfortunate. Luckily, Rust has a feature that gives us a better | ||
| way: generics. Generics are called **parametric polymorphism** in type theory, | ||
| which means that they are types or functions that have multiple forms ("poly" | ||
| is multiple, "morph" is form) over a given parameter ("parametric"). |
There was a problem hiding this comment.
What's the reason for removing the explanation of the word?
There was a problem hiding this comment.
I was thinking the guide's audience is expected to know what polymorphism is.
|
Some nits, but this looks great overall. Thank you! |
|
Needs a rebase |
Mostly copy-editing, clarification---in particular, monomorphization
|
Ah, ninja'd the commits in without a comment. @steveklabnik r? |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 2, 2015
Nothing major. Clarification, copy-editing, typographical and grammatical consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing major. Clarification, copy-editing, typographical and grammatical consistency