libs: make Cow usable, improve documentation #19157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes `Cow` more usable by allowing it to be applied to unsized types (as was intended) and providing some basic `ToOwned` implementations on slice types. It also corrects the documentation for `Cow` to no longer mention `DerefMut`, and adds an example.
| //! methods directly on the data it encloses. The first time a mutable reference | ||
| //! is required, the data will be cloned (via `to_owned`) if it is not | ||
| //! already owned. | ||
| //! `Cow` implements both `Deref`, which means that you can call |
|
This is actually really cool, I didn't know we had this 🐄 |
| @@ -609,6 +609,11 @@ impl BorrowFrom<String> for str { | |||
| fn borrow_from(owned: &String) -> &str { owned[] } | |||
| } | |||
|
|
|||
| #[unstable = "trait is unstable"] | |||
| impl ToOwned<String> for str { | |||
| fn to_owned(&self) -> String { self.to_string() } | |||
There was a problem hiding this comment.
This should use into_string. to_string goes through the formatting infrastructure, and tends to over-allocate space in the heap. See this playpen example, and also see #16415.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 22, 2014
This commit makes `Cow` more usable by allowing it to be applied to unsized types (as was intended) and providing some basic `ToOwned` implementations on slice types. It also corrects the documentation for `Cow` to no longer mention `DerefMut`, and adds an example.
bors
added a commit
that referenced
this pull request
Nov 23, 2014
This commit makes `Cow` more usable by allowing it to be applied to unsized types (as was intended) and providing some basic `ToOwned` implementations on slice types. It also corrects the documentation for `Cow` to no longer mention `DerefMut`, and adds an example. Closes #19123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes
Cowmore usable by allowing it to be applied tounsized types (as was intended) and providing some basic
ToOwnedimplementations on slice types. It also corrects the documentation for
Cowto no longer mentionDerefMut, and adds an example.Closes #19123