Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libc: only provide an rlib. #14633

Merged
merged 1 commit into from
Jun 5, 2014
Merged

libc: only provide an rlib. #14633

merged 1 commit into from
Jun 5, 2014

Conversation

huonw
Copy link
Member

@huonw huonw commented Jun 3, 2014

libc: only provide an rlib.

There's absolutely no reason for libc to be offered as a dynamic
library.

@alexcrichton
Copy link
Member

In general I don't think that we want to avoid dylibs once you've gotten past the standard library, but the dependencies underneath the standard library can in general be available only as rlibs.

@sfackler
Copy link
Member

sfackler commented Jun 4, 2014

Travis failure looks legit

@alexcrichton
Copy link
Member

Sneaky, sneaky. It looks like #14344 strikes again.

I've gotten around this in the past with:

// liblibc/lib.rs
#[doc(hidden)]
pub fn issue_14344_workaround() {}

// libstd/lib.rs
#[doc(hidden)]
pub fn issue_14344_workaround() {
    libc::issue_14344_workaround();
}

There's absolutely no reason for `libc` to be offered as a dynamic
library.
bors added a commit that referenced this pull request Jun 4, 2014
libc: only provide an rlib.

There's absolutely no reason for `libc` to be offered as a dynamic
library.
@bors bors closed this Jun 5, 2014
@bors bors merged commit 96cc48f into rust-lang:master Jun 5, 2014
@huonw huonw deleted the nodylibc branch June 27, 2014 06:47
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2023
internal: Don't reparse files when trying to expand assoc item macro calls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants