regex: Make some general tweaks #13863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AST doesn't need ~s everywhere, so we can save allocations this way & the enum isn't particularly large (~4 words) nor are regexes long (normally), so the space saved in the `Cat` vector is unlikely to be very much.
For loops are nicer than manual whiles, etc.
| @@ -309,7 +307,7 @@ fn exec<'t>(which: ::regex::native::MatchKind, input: &'t str, | |||
|
|
|||
| ::regex::Regex { | |||
| original: ~$regex, | |||
| names: ~$cap_names, | |||
| names: vec!$cap_names, | |||
There was a problem hiding this comment.
whoa, I had no idea that even worked!
bors
added a commit
that referenced
this pull request
Apr 30, 2014
Mostly code style e.g. avoiding `~` and using `for` + iterators.
arcnmx
pushed a commit
to arcnmx/rust
that referenced
this pull request
Jan 9, 2023
minor: suppress 'clippy::approx_constant' lint in test case suppresses a false positive clippy lint
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 9, 2025
…ang#13863) Fixes rust-lang#13862 `missing_headers::check` is sometimes called from outside of a body (specifically, from `check_attributes`, where the LateContext's ParamEnv is not yet properly initialized for that item). Using that empty ParamEnv for trait solving things from within the body can then lead to various ICEs, like the linked issue where we have a const generic parameter `DMA_INST` without a `ConstArgHasType` bound in the ParamEnv so the const parameter has no type, which is normally not supposed to happen. We have the item's DefId so we can just get its ParamEnv/TypingEnv from there, and using that one for trait solving should be safe. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly code style e.g. avoiding
~and usingfor+ iterators.