-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade 32-bit Windows SDK to 10.0.22621.0 in CI #137766
Conversation
This reverts commit 6ea4823.
r? @marcoieni rustbot has assigned @marcoieni. Use |
@bors try |
…try> Downgrade 32-bit Windows SDK to 10.0.22621.0 in CI Reverts 6ea4823 and worksaround rust-lang#137733 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@bors try |
…try> Downgrade 32-bit Windows SDK to 10.0.22621.0 in CI Reverts 6ea4823 and worksaround rust-lang#137733 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
914fb4d
to
ef69323
Compare
@bors try |
…try> Downgrade 32-bit Windows SDK to 10.0.22621.0 in CI Reverts 6ea4823 and worksaround rust-lang#137733 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@bors try |
…try> Downgrade 32-bit Windows SDK to 10.0.22621.0 in CI Reverts 6ea4823 and worksaround rust-lang#137733 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@bors try |
…try> Downgrade 32-bit Windows SDK to 10.0.22621.0 in CI Reverts 6ea4823 and worksaround rust-lang#137733 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@bors try |
…try> Downgrade 32-bit Windows SDK to 10.0.22621.0 in CI Reverts 6ea4823 and worksaround rust-lang#137733 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
354ff1a
to
1a16f50
Compare
This comment has been minimized.
This comment has been minimized.
@bors try |
…try> Downgrade 32-bit Windows SDK to 10.0.22621.0 in CI Reverts 6ea4823 and worksaround rust-lang#137733 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
1a16f50
to
1fb51d5
Compare
@bors try |
…try> Downgrade 32-bit Windows SDK to 10.0.22621.0 in CI Reverts 6ea4823 and worksaround rust-lang#137733 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
Sorry that was so noisy but I'm fairly confident this will work now. If it doesn't then I also made #137753 which removes the new SDK version. However, I personally prefer this PR as that is a big sledgehammer and may be more flaky (e.g. if deleting fails for some reason or an even newer SDK version is released). |
The job Click to see the possible cause of the failure (guessed by this bot)
|
The job Click to see the possible cause of the failure (guessed by this bot)
|
Oh hm, maybe I was overconfident. I don't understand the result though. cc-rs reports that the older SDK is being used (
But then the error indicates that the new SDK is being used (
Maybe the sledgehammer PR is better after all. I just wish I knew what was going on here. |
💔 Test failed - checks-actions |
Oh this might be LLVM configuring MSVC itself. We should really be ensuring they're consistent but apparently we don't. |
Remove latest Windows SDK from 32-bit CI This is an alternative to rust-lang#137766, in case that doesn't work. It is in some ways simpler but is less principled and may be more flaky (as it involves deleting stuff). try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: dist-i686-msvc
Ok I'm closing this. In retrospect, trying to thread the needle between at least two build systems is more than a simple job. The workaround works well enough for now. I can always revisit this if need be. |
Reverts 6ea4823 and worksaround #137733
try-job: i686-msvc-1
try-job: i686-msvc-2
try-job: dist-i686-msvc