Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 32-bit MSVC CI #137749

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Fix 32-bit MSVC CI #137749

merged 1 commit into from
Feb 28, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Feb 27, 2025

By throwing more hardware at it. The large runners should still use the old image. This could buy us a couple of... hours? Days? Who knows.

See #137733 for context.

r? @ghost

try-job: i686-msvc-1
try-job: i686-msvc-2
try-job: dist-i686-msvc

By throwing more hardware at it.
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 27, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 27, 2025

@bors r+ p=101

Let's just try to merge it directly, to avoid waiting another 3 hours for a try build..

@bors
Copy link
Contributor

bors commented Feb 27, 2025

📌 Commit 6ea4823 has been approved by Kobzol

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 27, 2025

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2025
@bors
Copy link
Contributor

bors commented Feb 27, 2025

⌛ Testing commit 6ea4823 with merge f45d4ac...

@bors
Copy link
Contributor

bors commented Feb 28, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing f45d4ac to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 28, 2025
@bors bors merged commit f45d4ac into rust-lang:master Feb 28, 2025
7 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 28, 2025
@cuviper
Copy link
Member

cuviper commented Feb 28, 2025

I'm grabbing this for beta #137747 too.

@rustbot label beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 28, 2025
@cuviper cuviper mentioned this pull request Feb 28, 2025
@cuviper cuviper modified the milestones: 1.87.0, 1.86.0 Feb 28, 2025
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f45d4ac): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 770.531s -> 770.19s (-0.04%)
Artifact size: 361.97 MiB -> 362.00 MiB (0.01%)

@Kobzol Kobzol deleted the fix-ci-2 branch February 28, 2025 06:58
@cuviper cuviper removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 28, 2025
@cuviper cuviper modified the milestones: 1.86.0, 1.87.0 Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants