Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gcc submodule #137660

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Update gcc submodule #137660

merged 1 commit into from
Feb 26, 2025
+1 −1

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Feb 26, 2025 •
edited
Loading

To add support for the x87 feature (see #137612 (comment)).

r? @antoyo

@Kobzol
Update gcc submodule
ee8ed8c 
To add support for the x87 feature.
@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2025

Failed to set assignee to antoyo: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2025

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 26, 2025
@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 26, 2025

r? @GuillaumeGomez

@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 26, 2025

📌 Commit ee8ed8c has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2025
fmease added a commit to fmease/rust that referenced this pull request Feb 26, 2025
@fmease
Rollup merge of rust-lang#137660 - Kobzol:gcc-update, r=GuillaumeGomez
ee2b7d6 
Update gcc submodule

To add support for the x87 feature (see rust-lang#137612 (comment)).

r? `@antoyo`
@fmease fmease mentioned this pull request Feb 26, 2025
Closed
@antoyo
Copy link
Contributor

antoyo commented Feb 26, 2025

Do you also need to update the git hash of the GCC repo in the 2 files that contain it?

@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 26, 2025

The build-gccjit.sh file is gone already, we now build GCC from the submodule version in the repo. The libgccjit.version file in the compiler directory isn't currently used by rustc, but it would be nice to synchronize this file with the submodule SHA when doing cg_gcc sync pushes to rustc.

@GuillaumeGomez
Copy link
Member

Why not removing libgccjit.version from compiler directory and use the one in the cg_gcc subtree?

@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 26, 2025

To clarify, the libgccjit.version file I was talking about is compiler/rustc_codegen_gcc/libgccjit.version, which comes from the compiler/rustc_codegen_gcc git subtree.

@GuillaumeGomez
Copy link
Member

Ah my bad. Then what about adding a small check to ensure that both SHA are the same? Like that we're sure it won't be missed out during syncs.

@Kobzol Kobzol mentioned this pull request Feb 26, 2025
Open
@Kobzol
Copy link
Contributor Author

Kobzol commented Feb 26, 2025

Great idea! #137683

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2025
@bors
Auto merge of rust-lang#137672 - fmease:rollup-s52k75j, r=fmease
7a69888 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#134585 (remove `MaybeUninit::uninit_array`)
 - rust-lang#136187 (Use less CString in the examples of CStr.)
 - rust-lang#136457 (Expose algebraic floating point intrinsics)
 - rust-lang#137201 (Teach structured errors to display short `Ty<'_>`)
 - rust-lang#137620 (Fix `attr` cast for espidf)
 - rust-lang#137631 (Avoid collecting associated types for undefined trait)
 - rust-lang#137635 (Don't suggest constraining unstable associated types)
 - rust-lang#137642 (Rustc dev guide subtree update)
 - rust-lang#137660 (Update gcc submodule)
 - rust-lang#137670 (revert accidental change in get_closest_merge_commit)

r? `@ghost`
`@rustbot` modify labels: rollup
@fmease fmease mentioned this pull request Feb 26, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2025
@bors
Auto merge of rust-lang#137688 - fmease:rollup-gbeuj9j, r=fmease
00f2459 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#134585 (remove `MaybeUninit::uninit_array`)
 - rust-lang#136187 (Use less CString in the examples of CStr.)
 - rust-lang#137201 (Teach structured errors to display short `Ty<'_>`)
 - rust-lang#137620 (Fix `attr` cast for espidf)
 - rust-lang#137631 (Avoid collecting associated types for undefined trait)
 - rust-lang#137635 (Don't suggest constraining unstable associated types)
 - rust-lang#137642 (Rustc dev guide subtree update)
 - rust-lang#137660 (Update gcc submodule)
 - rust-lang#137670 (revert accidental change in get_closest_merge_commit)
 - rust-lang#137671 (Make -Z unpretty=mir suggest -Z dump-mir as well for discoverability)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bd9e38d into rust-lang:master Feb 26, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 26, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2025
@rust-timer
Unrolled build for rust-lang#137660
e8c106a 
Rollup merge of rust-lang#137660 - Kobzol:gcc-update, r=GuillaumeGomez

Update gcc submodule

To add support for the x87 feature (see rust-lang#137612 (comment)).

r? `@antoyo`
@Kobzol Kobzol deleted the gcc-update branch February 27, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.87.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Kobzol @rustbot @GuillaumeGomez @bors @antoyo