-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
librustdoc: Use pulldown-cmark-escape
for HTML escaping
#137285
Conversation
rustbot has assigned @GuillaumeGomez. Use |
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
Sorry @GuillaumeGomez, meant to r? @notriddle , but I'll take an approval from either of you 🤣 |
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
…ng, r=<try> librustdoc: Use `pulldown-cmark-escape` for HTML escaping Implementation of `@notriddle` 's [suggestion](rust-lang#137274 (comment)). Somewhat related to rust-lang#137274 , but the two PRs should be complementary. Local perf results look like a nice improvement! (so would love a perf run on the CI)
☀️ Try build successful - checks-actions |
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (658976a): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf. @bors rollup=never Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -0.4%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary -4.0%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 773.063s -> 772.977s (-0.01%) |
Nice, thanks! @bors r+ rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (f43e549): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 770.178s -> 770.825s (0.08%) |
Implementation of @notriddle 's suggestion.
Somewhat related to #137274 , but the two PRs should be complementary.
Local perf results look like a nice improvement! (so would love a perf run on the CI)