Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 11) #136258

Merged
merged 4 commits into from
Jan 31, 2025
Merged

rustdoc: rename issue-\d+.rs tests to have meaningful names (part 11) #136258

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fdef34b
Add URL and `crate_name` to test cases
notriddle Jan 29, 2025
eb457da
rustdoc: rename `issue-\d+.rs` tests to have meaningful names
notriddle Jan 29, 2025
a1a55a2
Give 104145, 103463, and 31948 more descriptive names
notriddle Jan 30, 2025
c17d568
Direct link 108459 to issues -> pull redirect
notriddle Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...c/intra-doc/auxiliary/issue-103463-aux.rs → ...i/intra-doc/auxiliary/issue-103463-aux.rs
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions tests/rustdoc/intra-doc/issue-103463.rs → tests/rustdoc-ui/intra-doc/ice-103463.rs
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh yeah, this is quite a specific regression test. Any more descriptive file name probably doesn't do it justice (like priv-use).

Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// https://github.com/rust-lang/rust/issues/103463
//@ check-pass

// The `Trait` is not pulled into the crate resulting in doc links in its methods being resolved.

Expand Down
1 change: 1 addition & 0 deletions tests/rustdoc/intra-doc/issue-104145.rs → tests/rustdoc-ui/intra-doc/ice-104145.rs
View file
Open in desktop
Copy link
Member

@fmease fmease Jan 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit that all of these ICE regression tests are super niche and that likely nobody will ever look at them again but I think it's worth spending some words on these ^^'. What about sth. like extern-trait-local-impl or non-local-trait-local-impl (with or without the ice- prefix)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have the ice prefix for test cases that have no assertions. It makes it clearer what's being tested.

Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// https://github.com/rust-lang/rust/issues/104145
//@ check-pass

// Doc links in `Trait`'s methods are resolved because it has a local impl.

Expand Down
0 tests/rustdoc/inline_cross/issue-28480.rs → ...ine_cross/doc-hidden-broken-link-28480.rs
View file
Open in desktop
File renamed without changes.
0 tests/rustdoc/inline_cross/issue-31948-1.rs → ...e_cross/doc-hidden-module-impl-31948-1.rs
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc-hidden-* is only half the truth, this also tests that trait impls of effectively private types aren't rendered. Maybe doc-hidden-or-priv-module-* or the like?

File renamed without changes.
0 tests/rustdoc/inline_cross/issue-31948-2.rs → ...e_cross/doc-hidden-module-impl-31948-2.rs
View file
Open in desktop
Copy link
Member

@fmease fmease Jan 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is accurate. Well, except that the test also checks for the absence of impl Bar for Wobble (Bar relates to the effectively private test cases) which I think doesn't make that much sense as a test case but yea.

File renamed without changes.
0 tests/rustdoc/inline_cross/issue-31948.rs → ...ine_cross/doc-hidden-module-impl-31948.rs
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit cfad7ad that created these files describes it as a "reachability" check. How about calling it "doc-reachability-impl"?

File renamed without changes.
0 tests/rustdoc/inline_cross/issue-32881.rs → ...tdoc/inline_cross/impl-dyn-trait-32881.rs
View file
Open in desktop
File renamed without changes.
0 tests/rustdoc/inline_cross/issue-33113.rs → tests/rustdoc/inline_cross/impl-ref-33113.rs
View file
Open in desktop
File renamed without changes.
0 tests/rustdoc/inline_cross/issue-76736-1.rs → ...doc/inline_cross/rustc-private-76736-1.rs
View file
Open in desktop
File renamed without changes.
0 tests/rustdoc/inline_cross/issue-76736-2.rs → ...doc/inline_cross/rustc-private-76736-2.rs
View file
Open in desktop
File renamed without changes.
0 tests/rustdoc/inline_cross/issue-76736-3.rs → ...doc/inline_cross/rustc-private-76736-3.rs
View file
Open in desktop
File renamed without changes.
0 tests/rustdoc/inline_cross/issue-76736-4.rs → ...doc/inline_cross/rustc-private-76736-4.rs
View file
Open in desktop
File renamed without changes.
0 ...sue-24183.method_no_where_self_sized.html → ...nds-24183.method_no_where_self_sized.html
View file
Open in desktop
File renamed without changes.
0 tests/rustdoc/inline_cross/issue-24183.rs → ...c/inline_cross/self-sized-bounds-24183.rs
View file
Open in desktop
File renamed without changes.
0 tests/rustdoc/inline_local/issue-32343.rs → ...stdoc/inline_local/doc-no-inline-32343.rs
View file
Open in desktop
File renamed without changes.
0 tests/rustdoc/inline_local/issue-28537.rs → ...stdoc/inline_local/pub-re-export-28537.rs
View file
Open in desktop
File renamed without changes.
0 tests/rustdoc/intra-doc/issue-82209.rs → tests/rustdoc/intra-doc/enum-self-82209.rs
View file
Open in desktop
File renamed without changes.
0 tests/rustdoc/intra-doc/issue-108459.rs → ...me-name-different-disambiguator-108459.rs
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(hah, [#]108459 isn't even an issue but a PR)

File renamed without changes.
0 tests/rustdoc/intra-doc/issue-66159.rs → ...a-doc/same-name-different-crates-66159.rs
View file
Open in desktop
File renamed without changes.
Loading