Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uefi: process: Fix args #136186

Merged
merged 1 commit into from
Jan 29, 2025
Merged

uefi: process: Fix args #136186

merged 1 commit into from
Jan 29, 2025

Conversation

Ayush1325
Copy link
Contributor

  • While working on process env support, I found that args were currently broken. Not sure how I missed it in the PR, but well here is the fix.
  • Additionally, no point in adding space at the end of args.

@Ayush1325
uefi: process: Fix args
9c4fd25 
- While working on process env support, I found that args were currently
  broken. Not sure how I missed it in the PR, but well here is the fix.
- Additionally, no point in adding space at the end of args.

Signed-off-by: Ayush Singh <[email protected]>
@rustbot
Copy link
Collaborator

rustbot commented Jan 28, 2025

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 28, 2025
@Noratrieb
Copy link
Member

looks correct to me, cc @nicholasbishop @dvdhrm

@Noratrieb
Copy link
Member

@bors r=nicholasbishop,Noratrieb

@bors
Copy link
Contributor

bors commented Jan 28, 2025

📌 Commit 9c4fd25 has been approved by nicholasbishop,Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2025
@fmease fmease mentioned this pull request Jan 29, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2025
@bors
Auto merge of rust-lang#136227 - fmease:rollup-ewpvznh, r=fmease
e384432 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#136121 (Deduplicate operand creation between scalars, non-scalars and string patterns)
 - rust-lang#136134 (Fix SIMD codegen tests on LLVM 20)
 - rust-lang#136153 (Locate asan-odr-win with other sanitizer tests)
 - rust-lang#136161 (rustdoc: add nobuild typescript checking to our JS)
 - rust-lang#136166 (interpret: is_alloc_live: check global allocs last)
 - rust-lang#136168 (GCI: Don't try to eval / collect mono items inside overly generic free const items)
 - rust-lang#136170 (Reject unsound toggling of Arm atomics-32 target feature)
 - rust-lang#136176 (Render pattern types nicely in mir dumps)
 - rust-lang#136186 (uefi: process: Fix args)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2025
@bors
Auto merge of rust-lang#136227 - fmease:rollup-ewpvznh, r=fmease
a1d7676 
Rollup of 9 pull requests

Successful merges:

 - rust-lang#136121 (Deduplicate operand creation between scalars, non-scalars and string patterns)
 - rust-lang#136134 (Fix SIMD codegen tests on LLVM 20)
 - rust-lang#136153 (Locate asan-odr-win with other sanitizer tests)
 - rust-lang#136161 (rustdoc: add nobuild typescript checking to our JS)
 - rust-lang#136166 (interpret: is_alloc_live: check global allocs last)
 - rust-lang#136168 (GCI: Don't try to eval / collect mono items inside overly generic free const items)
 - rust-lang#136170 (Reject unsound toggling of Arm atomics-32 target feature)
 - rust-lang#136176 (Render pattern types nicely in mir dumps)
 - rust-lang#136186 (uefi: process: Fix args)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7e60f27 into rust-lang:master Jan 29, 2025
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 29, 2025
@rust-timer
Unrolled build for rust-lang#136186
8cf2f7f 
Rollup merge of rust-lang#136186 - Ayush1325:uefi-process-args-fix, r=nicholasbishop,Noratrieb

uefi: process: Fix args

- While working on process env support, I found that args were currently broken. Not sure how I missed it in the PR, but well here is the fix.
- Additionally, no point in adding space at the end of args.
@rustbot rustbot added this to the 1.86.0 milestone Jan 29, 2025
@Ayush1325 Ayush1325 deleted the uefi-process-args-fix branch January 29, 2025 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasbishop nicholasbishop nicholasbishop approved these changes

Assignees

@Noratrieb Noratrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Ayush1325 @rustbot @Noratrieb @bors @nicholasbishop