Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use ubuntu 24 on free runners #136136

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Conversation

marcoieni
Copy link
Member

@marcoieni marcoieni commented Jan 27, 2025

Updating to the newest ubuntu to take advantage of newer software and kernel version.
You can see the difference between the two images here:

As you can see, ubuntu 24 installs less software by default, which makes cleaning the disk for unused stuff easier.
All the linux jobs run in docker containers, so this change don't affect the rust builds.
After we merge this, I'll switch the large runners, too.

I'm not sure this is going to work for all jobs, so please merge this as a single PR in the auto build.

try-job: aarch64-gnu
try-job: aarch64-gnu-debug

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 27, 2025
@marcoieni
Copy link
Member Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 27, 2025
ci: use ubuntu 24 on free runners

try-job: aarch64-gnu
try-job: aarch64-gnu-debug
@bors
Copy link
Contributor

bors commented Jan 27, 2025

⌛ Trying commit ff19f2f with merge cdfd854...

@bors
Copy link
Contributor

bors commented Jan 27, 2025

☀️ Try build successful - checks-actions
Build commit: cdfd854 (cdfd85465f2aaf38f1eebcbfb02eb785f30686cd)

@marcoieni marcoieni marked this pull request as ready for review January 27, 2025 18:07
@marcoieni
Copy link
Member Author

@rustbot ready

@Kobzol
Copy link
Contributor

Kobzol commented Jan 27, 2025

This can in theory break a lot of runners, so no point in trying one by one. But I think/hope that it should be mostly fine.

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Jan 27, 2025

📌 Commit ff19f2f has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2025
@bors
Copy link
Contributor

bors commented Feb 1, 2025

⌛ Testing commit ff19f2f with merge e08cd3c...

@bors
Copy link
Contributor

bors commented Feb 1, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing e08cd3c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 1, 2025
@bors bors merged commit e08cd3c into rust-lang:master Feb 1, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 1, 2025
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e08cd3c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
4.6% [4.6%, 4.6%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 4.6% [4.6%, 4.6%] 1

Cycles

Results (secondary -1.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.9% [-1.9%, -1.9%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 777.638s -> 777.851s (0.03%)
Artifact size: 328.85 MiB -> 328.84 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants