Add a workaround for parallel rustc crashing when there are delayed bugs #135988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't fix the root cause of this crash, but at least stops it from happening for the time being.
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
rustbot
added
S-waiting-on-review
|
r? lqd |
|
Let's add the MCVE as a @rustbot author |
rustbot
added
S-waiting-on-author
|
Added @rustbot ready |
rustbot
added
S-waiting-on-review
lqd
reviewed
Jan 24, 2025
bjorn3
force-pushed
the
workaround_parallel_rustc_crash
branch
from
9e783e2 to
207a2a2
Compare
lqd
reviewed
Jan 26, 2025
| @@ -0,0 +1,6 @@ | |||
| //@ compile-flags: -Z threads=2 | |||
| //@ check-fail | |||
There was a problem hiding this comment.
Suggested change
| //@ check-fail |
That's the default and shouldn't be necessary?
|
r=me with or without the nit above |
bjorn3
force-pushed
the
workaround_parallel_rustc_crash
branch
from
207a2a2 to
6f543d5
Compare
|
@bors r=lqd |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 27, 2025
…llaumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#135773 (Clarify WindowsMut (Lending)Iterator) - rust-lang#135807 (Implement phantom variance markers) - rust-lang#135876 (fix doc for std::sync::mpmc) - rust-lang#135988 (Add a workaround for parallel rustc crashing when there are delayed bugs) - rust-lang#136037 (Mark all NuttX targets as tier 3 target and support the standard library) - rust-lang#136064 (Add a suggestion to cast target_feature fn items to fn pointers.) - rust-lang#136082 (Incorporate `iter_nodes` into `graph::DirectedGraph`) - rust-lang#136112 (Clean up all dead files inside `tests/ui/`) - rust-lang#136114 (Use identifiers more in diagnostics code) - rust-lang#136118 (Change `collect_and_partition_mono_items` tuple return type to a struct) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 27, 2025
Rollup merge of rust-lang#135988 - bjorn3:workaround_parallel_rustc_crash, r=lqd Add a workaround for parallel rustc crashing when there are delayed bugs This doesn't fix the root cause of this crash, but at least stops it from happening for the time being. Workaround for rust-lang#135870
This was referenced Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't fix the root cause of this crash, but at least stops it from happening for the time being.
Workaround for #135870